Skip to content

Conversation

@martin-belanger
Copy link

The following 3 types were renamed at some point, but not all instances were renamed in the docs and python examples.

NVME_LOG_LID_DISCOVER      -> NVME_LOG_LID_DISCOVERY
NVME_LOG_LID_HOST_DISCOVER -> NVME_LOG_LID_HOST_DISCOVERY
NVME_LOG_LID_AVE_DISCOVER  -> NVME_LOG_LID_AVE_DISCOVERY

The following 3 types were renamed at some point, but not all
instances were renamed in the docs and python examples.

NVME_LOG_LID_DISCOVER      -> NVME_LOG_LID_DISCOVERY
NVME_LOG_LID_HOST_DISCOVER -> NVME_LOG_LID_HOST_DISCOVERY
NVME_LOG_LID_AVE_DISCOVER  -> NVME_LOG_LID_AVE_DISCOVERY

Signed-off-by: Martin Belanger <martin.belanger@dell.com>
@igaw
Copy link
Collaborator

igaw commented Dec 5, 2025

  • the man page update is not necessary, it will be regenerated on release
  • the wrap update is also not really necessary

I'll fix it up myself next week (still busy with my hackweek project :)) unless you are faster than me :)

@martin-belanger
Copy link
Author

I will fix it today. I didn't realize the wrap file had been bundled in this PR. Not sure how this happened.

@martin-belanger
Copy link
Author

Closing. Will resubmit a fresh PR.

@martin-belanger martin-belanger deleted the rename_DISCOVER_to_DISCOVERY branch December 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants