dsm: add support for fallback from char device to block device #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent cleanup in the passthru code, the uring code was not updated. Since the calling code is not really interested in the status code from the nvme command, let's remove this for the time being. Fixes: 94b1e14 ("src: drop result argument from submit API") Signed-off-by: Daniel Wagner <wagi@kernel.org>
The dsm command is only supported by the block device. The kernel has support to map NVME_IOCTL_IO_CMD when user spaces uses the char device. Though for NVME_IOCTL_IO64_CMD this support is missing and wont be added to the kernel. Thus add the fallback code to userland. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvme: add fallback support for block vs char device to dsm command
The dsm command is only supported by the block device. The kernel has
support to map NVME_IOCTL_IO_CMD when user spaces uses the char device.
Though for NVME_IOCTL_IO64_CMD this support is missing and wont be added
to the kernel.
Thus add the fallback code to userland.
Fixes: #2991