Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Sep 19, 2025

and fix ansible-lint for podman
needed for podman bootc support PR
linux-system-roles/podman#245

Summary by Sourcery

Bump tox-lsr to version 3.12.0 and update ansible-lint configuration for the podman role

Build:

  • Update tox-lsr URL to use version 3.12.0

CI:

  • Add ansible-lint skip_list for podman to ignore the unignorable sanity rule

and fix ansible-lint for podman
needed for podman bootc support PR
linux-system-roles/podman#245
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the CI configuration by bumping the tox-lsr dependency to version 3.12.0 and enhances the ansible-lint setup for the podman role by adding a skip rule for the ‘sanity’ check.

File-Level Changes

Change Details Files
Bump tox-lsr dependency to 3.12.0
  • Updated tox_lsr_url to point at v3.12.0 repository
inventory/group_vars/active_roles.yml
Enhance ansible-lint config for podman
  • Added skip_list entry to ignore the ‘sanity’ rule
inventory/host_vars/podman.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@richm richm merged commit 0e771b2 into linux-system-roles:main Sep 19, 2025
1 check was pending
@richm richm deleted the podman-ansible-lint-sanity branch September 19, 2025 18:47
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant