ci: Pass in __bootc_validation as boolean, not string #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR enhances CI by updating local testing docs, modernizing GitHub Action workflows (checkout version bump, tox-lsr upgrade), passing the __bootc_validation flag as a YAML boolean, and refining the TF CITest failure logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- This PR bundles the __bootc_validation boolean fix with broad CI workflow version bumps and docs additions—consider splitting into focused PRs to keep changes scoped and reviews simpler.
- The new “Running CI Tests Locally” section is comprehensive but quite long—consider extracting it into a standalone reference doc and linking from contributing.md to avoid clutter.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- This PR bundles the __bootc_validation boolean fix with broad CI workflow version bumps and docs additions—consider splitting into focused PRs to keep changes scoped and reviews simpler.
- The new “Running CI Tests Locally” section is comprehensive but quite long—consider extracting it into a standalone reference doc and linking from contributing.md to avoid clutter.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass in a YAML true value as
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Improve CI reliability and consistency by treating __bootc_validation as a boolean, extending failure detection to cancelled runs, upgrading checkout actions and tox-lsr versions, and enhancing documentation for local CI testing.
Bug Fixes:
Enhancements:
Documentation: