ci: rollout several recent changes to CI testing #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR standardizes and modernizes CI configurations by upgrading the GitHub checkout action, bumping tox-lsr to the latest patch, correcting boolean variable handling, extending failure detection for canceled runs, and enriching local CI test documentation. Sequence diagram for improved failure/cancellation detection in tft_citest_bad workflowsequenceDiagram
participant "GitHub Actions"
participant "gh CLI"
participant "tft_citest_bad workflow"
"tft_citest_bad workflow"->>"gh CLI": Query workflow runs for PR title
"gh CLI"-->>"tft_citest_bad workflow": Return runs with conclusion "failure" or "cancelled"
"tft_citest_bad workflow"->>"GitHub Actions": If run found, post bad comment
"tft_citest_bad workflow"->>"GitHub Actions": If not found, exit
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- A lot of repetitive version bumps and checkout updates across workflows could be consolidated into a reusable workflow or a single variables file to simplify future maintenance.
- The new "Running CI Tests Locally" section in contributing.md is quite lengthy—consider extracting it into its own guide and linking to it instead of embedding all details inline.
- Verify that the change to quote
__bootc_validation: trueis consistently applied across all relevant workflows and update any documentation or examples accordingly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- A lot of repetitive version bumps and checkout updates across workflows could be consolidated into a reusable workflow or a single variables file to simplify future maintenance.
- The new "Running CI Tests Locally" section in contributing.md is quite lengthy—consider extracting it into its own guide and linking to it instead of embedding all details inline.
- Verify that the change to quote `__bootc_validation: true` is consistently applied across all relevant workflows and update any documentation or examples accordingly.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips