Skip to content

Conversation

@HVSharma12
Copy link
Contributor

@HVSharma12 HVSharma12 commented Oct 29, 2025

Enhancement: Fix role failure on SLES 15. Added Distro specific vars to include missing package.

Reason: Role fails on SLES15 requires python311-firewall package which is not installed by default by the firewalld package.

Result: Distro specific vars install python311-firewall for SLES 15

Issue Tracker Tickets (Jira or BZ if any): NA

Summary by Sourcery

Bug Fixes:

  • Add SLES_15 and SLES_SAP_15 vars files to install python311-firewall

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduce SLES 15 and SLES_SAP 15–specific variable files to ensure the python311-firewall package is installed, resolving role failures on SLES 15.

Entity relationship diagram for new SLES 15 distro-specific variables

erDiagram
    SLES_15 {
        string __firewall_packages_extra
    }
    SLES_SAP_15 {
        string __firewall_packages_extra
    }
    SLES_15 ||--|| SLES_SAP_15 : "similar structure"
Loading

Class diagram for new SLES 15 and SLES_SAP 15 variable files

classDiagram
    class SLES_15 {
        +__firewall_packages_extra: list[string]
    }
    class SLES_SAP_15 {
        +__firewall_packages_extra: list[string]
    }
    SLES_15 <|-- SLES_SAP_15
Loading

File-Level Changes

Change Details Files
Create distro-specific variable files to include python311-firewall
  • Add vars/SLES_15.yml defining __firewall_packages_extra for SLES 15
  • Add vars/SLES_SAP_15.yml defining __firewall_packages_extra for SLES_SAP_15
vars/SLES_15.yml
vars/SLES_SAP_15.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.26%. Comparing base (2d7c4ba) to head (19c2761).
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   61.09%   58.26%   -2.83%     
==========================================
  Files           2        2              
  Lines         910     1294     +384     
==========================================
+ Hits          556      754     +198     
- Misses        354      540     +186     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit d2f1775 into linux-system-roles:main Nov 3, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants