-
Notifications
You must be signed in to change notification settings - Fork 35
fix: install python311-firewall on SLES 15 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install python311-firewall on SLES 15 #300
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduce SLES 15 and SLES_SAP 15–specific variable files to ensure the python311-firewall package is installed, resolving role failures on SLES 15. Entity relationship diagram for new SLES 15 distro-specific variableserDiagram
SLES_15 {
string __firewall_packages_extra
}
SLES_SAP_15 {
string __firewall_packages_extra
}
SLES_15 ||--|| SLES_SAP_15 : "similar structure"
Class diagram for new SLES 15 and SLES_SAP 15 variable filesclassDiagram
class SLES_15 {
+__firewall_packages_extra: list[string]
}
class SLES_SAP_15 {
+__firewall_packages_extra: list[string]
}
SLES_15 <|-- SLES_SAP_15
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 61.09% 58.26% -2.83%
==========================================
Files 2 2
Lines 910 1294 +384
==========================================
+ Hits 556 754 +198
- Misses 354 540 +186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enhancement: Fix role failure on SLES 15. Added Distro specific vars to include missing package.
Reason: Role fails on SLES15 requires python311-firewall package which is not installed by default by the firewalld package.
Result: Distro specific vars install python311-firewall for SLES 15
Issue Tracker Tickets (Jira or BZ if any): NA
Summary by Sourcery
Bug Fixes: