ci: rollout several recent changes to CI testing

[richm]

• Pass in a YAML true value as __bootc_validation: true using
  the --extra-vars option to ensure that __bootc_validation is
  treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

• Use tox-lsr version 3.11.1

• Ensure the citest bad comment works when the test was cancelled in
  addition to the failure case.

• Update contributing.md documentation

• Update number of nodes to use in testing farm, if needed

• remove unnecessary ansible-lint skips

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows and documentation for improved testing consistency and usability

CI:

• Upgrade tox-lsr to version 3.11.1 across GitHub Actions workflows
• Pass __bootc_validation as a YAML boolean string in qemu-ansible Core CI
• Include cancelled runs alongside failures when identifying bad test workflows

Documentation:

• Expand contributing.md with local QEMU-based CI testing instructions using tox-lsr

[sourcery-ai]

Reviewer's Guide

This PR enhances CI reliability by passing a proper YAML boolean for bootc validation, upgrading tox-lsr to 3.11.1 across workflows, extending the citest bad comment logic to cancelled runs, and adding detailed local CI testing instructions to the contributing guide.

File-Level Changes

Change	Details	Files
Ensure __bootc_validation is passed as a YAML boolean	Quote the extra-vars parameter in the qemu-kvm workflow to -e "__bootc_validation: true" Update the test invocation to treat __bootc_validation as a boolean, not a string	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr to version 3.11.1 in CI workflows	Update pip3 install commands to reference tox-lsr@3.11.1 Maintain consistent tox-lsr version across all test jobs	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Include cancelled runs in the citest bad comment workflow	Extend the jq filter to select conclusions of failure or cancelled Add a comment noting that TF tests may be cancelled due to internal issues	.github/workflows/tft_citest_bad.yml
Add local CI testing instructions to the contributing guide	Introduce a new section on using tox-lsr with qemu for local CI runs Provide step-by-step setup for dependencies, config file, and test commands	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider defining the tox-lsr version as a single reusable variable or matrix in your GitHub workflows to avoid having to bump it manually in multiple places.
• The extensive qemu setup instructions in contributing.md could be moved to a dedicated guide or linked repository to keep the main doc concise and easier to maintain.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider defining the tox-lsr version as a single reusable variable or matrix in your GitHub workflows to avoid having to bump it manually in multiple places.
- The extensive qemu setup instructions in contributing.md could be moved to a dedicated guide or linked repository to keep the main doc concise and easier to maintain.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}