Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Nov 17, 2025

Update changelog and .README.html for version 1.0.4

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Bump to version 1.0.4, document a key bug fix and extensive CI updates in the changelog, and refine code block styling in the HTML README.

Bug Fixes:

  • Fix inability to use community-general version 12 due to missing Python 2.7 and 3.6 support

Enhancements:

  • Disable ansible-plugin-scan and bump various CI dependencies, test plans, and action versions to streamline testing workflows

Documentation:

  • Update CHANGELOG.md for the 1.0.4 release
  • Adjust .README.html CSS to improve code block rendering and text-size behavior

Update changelog and .README.html for version 1.0.4

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 17, 2025

Reviewer's Guide

Updates CHANGELOG.md to document the 1.0.4 release (bug fix and CI improvements) and refines code block CSS rules in .README.html for better display and print formatting.

Flow diagram for updated code block CSS rules in .README.html

flowchart TD
    A["pre > code.sourceCode"] --> B["span inside code block"]
    B --> C["Display: inline-block; Line-height: 1.25"]
    B --> D["@media print: Text-indent: -5em; Padding-left: 5em"]
    A --> E["html: -webkit-text-size-adjust: 100%"]
    A --> F["pre > code.sourceCode > span:empty: Height: 1.2em"]
    A --> G[".sourceCode: Overflow: visible"]
    G --> H["code.sourceCode > span: Color/Text-decoration: inherit"]
Loading

File-Level Changes

Change Details Files
Add changelog entry for version 1.0.4
  • Insert new version header with release date
  • Add bug fix bullet for community-general version support
  • List multiple CI-related enhancements and bumps
CHANGELOG.md
Refine code block styling in .README.html
  • Add html { -webkit-text-size-adjust: 100%; } rule
  • Update display property for .sourceCode span elements
  • Adjust text-indent and padding settings in print media
.README.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.README.html:61` </location>
<code_context>
   </style>
   <style type="text/css">code{white-space: pre;}</style>
   <style type="text/css">
+html { -webkit-text-size-adjust: 100%; }
 pre > code.sourceCode { white-space: pre; position: relative; }
-pre > code.sourceCode > span { line-height: 1.25; }
</code_context>

<issue_to_address>
**suggestion:** Consider cross-browser compatibility for text size adjustment.

Add -ms-text-size-adjust and -moz-text-size-adjust for broader browser support.

```suggestion
html {
  -webkit-text-size-adjust: 100%;
  -ms-text-size-adjust: 100%;
  -moz-text-size-adjust: 100%;
}
```
</issue_to_address>

### Comment 2
<location> `CHANGELOG.md:17` </location>
<code_context>
+- ci: bump ansible-lint to v25; provide collection requirements for ansible-lint (#42)
+- ci: Check spelling with codespell (#43)
+- ci: Add test plan that runs CI tests and customize it for each role (#44)
+- ci: In test plans, prefix all relate variables with SR_ (#45)
+- ci: Fix bug with ARTIFACTS_URL after prefixing with SR_ (#46)
+- ci: several changes related to new qemu test, ansible-lint, python versions, ubuntu versions (#47)
</code_context>

<issue_to_address>
**suggestion (typo):** Consider changing 'relate' to 'related' for grammatical correctness.

Use 'related' instead of 'relate' for correct grammar in the phrase.

```suggestion
- ci: In test plans, prefix all related variables with SR_ (#45)
```
</issue_to_address>

### Comment 3
<location> `CHANGELOG.md:28` </location>
<code_context>
+- ci: Add support for bootc end-to-end validation tests (#53)
+- ci: Use ansible 2.19 for fedora 42 testing; support python 3.13 (#54)
+- ci: bump actions/checkout from 4 to 5 (#55)
+- ci: rollout several recent changes to CI testing (#57)
+- ci: support openSUSE Leap in qemu/kvm test matrix (#58)
+- ci: use the new epel feature to enable EPEL for testing farm (#59)
</code_context>

<issue_to_address>
**suggestion (typo):** Consider changing 'rollout' to 'roll out' for correct verb usage.

Use 'roll out' as a verb here, rather than the noun 'rollout.'

```suggestion
- ci: roll out several recent changes to CI testing (#57)
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

</style>
<style type="text/css">code{white-space: pre;}</style>
<style type="text/css">
html { -webkit-text-size-adjust: 100%; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider cross-browser compatibility for text size adjustment.

Add -ms-text-size-adjust and -moz-text-size-adjust for broader browser support.

Suggested change
html { -webkit-text-size-adjust: 100%; }
html {
-webkit-text-size-adjust: 100%;
-ms-text-size-adjust: 100%;
-moz-text-size-adjust: 100%;
}

@richm richm merged commit f895d73 into linux-system-roles:main Nov 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant