-
Notifications
You must be signed in to change notification settings - Fork 5
docs(changelog): version 1.0.4 [citest skip] #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update changelog and .README.html for version 1.0.4 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideUpdates CHANGELOG.md to document the 1.0.4 release (bug fix and CI improvements) and refines code block CSS rules in .README.html for better display and print formatting. Flow diagram for updated code block CSS rules in .README.htmlflowchart TD
A["pre > code.sourceCode"] --> B["span inside code block"]
B --> C["Display: inline-block; Line-height: 1.25"]
B --> D["@media print: Text-indent: -5em; Padding-left: 5em"]
A --> E["html: -webkit-text-size-adjust: 100%"]
A --> F["pre > code.sourceCode > span:empty: Height: 1.2em"]
A --> G[".sourceCode: Overflow: visible"]
G --> H["code.sourceCode > span: Color/Text-decoration: inherit"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.README.html:61` </location>
<code_context>
</style>
<style type="text/css">code{white-space: pre;}</style>
<style type="text/css">
+html { -webkit-text-size-adjust: 100%; }
pre > code.sourceCode { white-space: pre; position: relative; }
-pre > code.sourceCode > span { line-height: 1.25; }
</code_context>
<issue_to_address>
**suggestion:** Consider cross-browser compatibility for text size adjustment.
Add -ms-text-size-adjust and -moz-text-size-adjust for broader browser support.
```suggestion
html {
-webkit-text-size-adjust: 100%;
-ms-text-size-adjust: 100%;
-moz-text-size-adjust: 100%;
}
```
</issue_to_address>
### Comment 2
<location> `CHANGELOG.md:17` </location>
<code_context>
+- ci: bump ansible-lint to v25; provide collection requirements for ansible-lint (#42)
+- ci: Check spelling with codespell (#43)
+- ci: Add test plan that runs CI tests and customize it for each role (#44)
+- ci: In test plans, prefix all relate variables with SR_ (#45)
+- ci: Fix bug with ARTIFACTS_URL after prefixing with SR_ (#46)
+- ci: several changes related to new qemu test, ansible-lint, python versions, ubuntu versions (#47)
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing 'relate' to 'related' for grammatical correctness.
Use 'related' instead of 'relate' for correct grammar in the phrase.
```suggestion
- ci: In test plans, prefix all related variables with SR_ (#45)
```
</issue_to_address>
### Comment 3
<location> `CHANGELOG.md:28` </location>
<code_context>
+- ci: Add support for bootc end-to-end validation tests (#53)
+- ci: Use ansible 2.19 for fedora 42 testing; support python 3.13 (#54)
+- ci: bump actions/checkout from 4 to 5 (#55)
+- ci: rollout several recent changes to CI testing (#57)
+- ci: support openSUSE Leap in qemu/kvm test matrix (#58)
+- ci: use the new epel feature to enable EPEL for testing farm (#59)
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing 'rollout' to 'roll out' for correct verb usage.
Use 'roll out' as a verb here, rather than the noun 'rollout.'
```suggestion
- ci: roll out several recent changes to CI testing (#57)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| </style> | ||
| <style type="text/css">code{white-space: pre;}</style> | ||
| <style type="text/css"> | ||
| html { -webkit-text-size-adjust: 100%; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider cross-browser compatibility for text size adjustment.
Add -ms-text-size-adjust and -moz-text-size-adjust for broader browser support.
| html { -webkit-text-size-adjust: 100%; } | |
| html { | |
| -webkit-text-size-adjust: 100%; | |
| -ms-text-size-adjust: 100%; | |
| -moz-text-size-adjust: 100%; | |
| } |
Update changelog and .README.html for version 1.0.4
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Bump to version 1.0.4, document a key bug fix and extensive CI updates in the changelog, and refine code block styling in the HTML README.
Bug Fixes:
Enhancements:
Documentation: