Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 5, 2025

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update QEMU integration test matrix to target newer Fedora images while removing obsolete ones.

CI:

  • Add Fedora 43 QEMU and container images (including bootc variants) to the GitHub Actions integration test matrix using ansible-core 2.19.
  • Remove Fedora 41 QEMU and container images from the GitHub Actions integration test matrix.

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Dec 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the GitHub Actions QEMU/KVM integration test matrix to stop testing Fedora 41 and start testing Fedora 43 for both QEMU and container-based runs, aligning Fedora images with newer ansible-core versions.

File-Level Changes

Change Details Files
Update QEMU integration test matrix to add Fedora 43 and adjust ansible-core versions.
  • Remove commented-out Fedora 41 QEMU entry that referenced an ansible/libdnf5 bug.
  • Keep Fedora 42 QEMU entry at ansible-core 2.19.
  • Add a Fedora 43 QEMU entry using ansible-core 2.19.
.github/workflows/qemu-kvm-integration-tests.yml
Update container-based integration test matrix to drop Fedora 41 images and add Fedora 43 images with newer ansible-core.
  • Remove Fedora 41 container image from the test matrix.
  • Remove Fedora 41 bootc container image from the test matrix.
  • Add Fedora 43 container image using ansible-core 2.19.
  • Add Fedora 43 bootc container image using ansible-core 2.19 while keeping Fedora 42 and Fedora 42 bootc entries unchanged.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • For consistency and easier maintenance, consider aligning the ansible-core versions used by Fedora container images (e.g., bumping the remaining fedora-42 container jobs from 2.17 to 2.19 if compatible) so that Fedora versions use the same ansible-core level across QEMU and container tests.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For consistency and easier maintenance, consider aligning the ansible-core versions used by Fedora container images (e.g., bumping the remaining `fedora-42` container jobs from `2.17` to `2.19` if compatible) so that Fedora versions use the same ansible-core level across QEMU and container tests.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 0ee9e70 into main Dec 5, 2025
41 checks passed
@richm richm deleted the ci-qemu-fedora-43 branch December 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants