Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Oct 21, 2025

Update changelog and .README.html for version 1.26.0

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Prepare release v1.26.0 with new cluster export capabilities, CI improvements, refactoring cleanup, and updated documentation.

New Features:

  • Export Pacemaker cluster properties and resource defaults including resource operation defaults

Enhancements:

  • Allow long lines in fixture_psks.yml
  • Refactor by removing unused pcs_provider variable
  • Enhance CI by running ansible-lint after role conversion, bumping actions/checkout to v5, rolling out CI testing updates, supporting openSUSE Leap, enabling EPEL feature for testing farm, updating tox-lsr to 3.12.0, using JSON for __bootc_validation, bumping actions/github-script to v8, and adding tmt plans for GitLab CI

Documentation:

  • Update changelog for version 1.26.0
  • Update README.html to list new exported variables: ha_cluster_cluster_properties, ha_cluster_resource_defaults, and ha_cluster_resource_operation_defaults

Update changelog and .README.html for version 1.26.0

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from tomjelinek as a code owner October 21, 2025 17:05
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 21, 2025

Reviewer's Guide

This PR updates documentation for version 1.26.0 by adding new changelog entries and reflecting new cluster export options in the README HTML.

Class diagram for new exported cluster properties and resource defaults

classDiagram
    class ha_cluster_cluster_properties {
        <<exported variable>>
    }
    class ha_cluster_resource_defaults {
        <<exported variable>>
    }
    class ha_cluster_resource_operation_defaults {
        <<exported variable>>
    }
    class ha_cluster_resource_clones {
        <<exported variable>>
    }
    class ha_cluster_resource_bundles {
        <<exported variable>>
    }
    ha_cluster_cluster_properties --|> ha_cluster_resource_defaults
    ha_cluster_resource_defaults --|> ha_cluster_resource_operation_defaults
    ha_cluster_resource_clones --|> ha_cluster_resource_bundles
Loading

File-Level Changes

Change Details Files
Add version 1.26.0 changelog entries
  • Insert 1.26.0 section header with release date
  • Add new feature and other changes bullets for exports, CI, style, and refactor
CHANGELOG.md
Update .README.html with new cluster export options
  • Replace limitations list to include cluster properties, stonith/resources, and defaults
  • Add exported variable anchors for cluster properties and resource defaults
.README.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.README.html:1952-1953` </location>
<code_context>
+<li><a
+href="#ha_cluster_cluster_properties"><code>ha_cluster_cluster_properties</code></a></li>
</code_context>

<issue_to_address>
**suggestion:** New exported variables are listed without context on their usage.

Consider adding a brief note or example to clarify the intended use of these new exported variables, especially if they introduce new functionality or configuration options.

```suggestion
<li><a
href="#ha_cluster_cluster_properties"><code>ha_cluster_cluster_properties</code></a></li>
<ul>
  <li><em>Example usage:</em> Set cluster-wide properties for Pacemaker, such as <code>no-quorum-policy</code> or <code>stonith-enabled</code>. For example:
    <pre><code>ha_cluster_cluster_properties:
  no-quorum-policy: "ignore"
  stonith-enabled: "true"
</code></pre>
  </li>
</ul>
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (ae6805b) to head (977b14c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files          13       13           
  Lines         980      980           
=======================================
  Hits          873      873           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit 2084835 into linux-system-roles:main Oct 21, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant