-
Notifications
You must be signed in to change notification settings - Fork 24
docs(changelog): version 1.26.0 [citest skip] #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update changelog and .README.html for version 1.26.0 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR updates documentation for version 1.26.0 by adding new changelog entries and reflecting new cluster export options in the README HTML. Class diagram for new exported cluster properties and resource defaultsclassDiagram
class ha_cluster_cluster_properties {
<<exported variable>>
}
class ha_cluster_resource_defaults {
<<exported variable>>
}
class ha_cluster_resource_operation_defaults {
<<exported variable>>
}
class ha_cluster_resource_clones {
<<exported variable>>
}
class ha_cluster_resource_bundles {
<<exported variable>>
}
ha_cluster_cluster_properties --|> ha_cluster_resource_defaults
ha_cluster_resource_defaults --|> ha_cluster_resource_operation_defaults
ha_cluster_resource_clones --|> ha_cluster_resource_bundles
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.README.html:1952-1953` </location>
<code_context>
+<li><a
+href="#ha_cluster_cluster_properties"><code>ha_cluster_cluster_properties</code></a></li>
</code_context>
<issue_to_address>
**suggestion:** New exported variables are listed without context on their usage.
Consider adding a brief note or example to clarify the intended use of these new exported variables, especially if they introduce new functionality or configuration options.
```suggestion
<li><a
href="#ha_cluster_cluster_properties"><code>ha_cluster_cluster_properties</code></a></li>
<ul>
<li><em>Example usage:</em> Set cluster-wide properties for Pacemaker, such as <code>no-quorum-policy</code> or <code>stonith-enabled</code>. For example:
<pre><code>ha_cluster_cluster_properties:
no-quorum-policy: "ignore"
stonith-enabled: "true"
</code></pre>
</li>
</ul>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 89.08% 89.08%
=======================================
Files 13 13
Lines 980 980
=======================================
Hits 873 873
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update changelog and .README.html for version 1.26.0
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Prepare release v1.26.0 with new cluster export capabilities, CI improvements, refactoring cleanup, and updated documentation.
New Features:
Enhancements:
Documentation: