Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Nov 15, 2025

ansible-test 2.14 in el9 still checks for py35

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Bug Fixes:

  • Remove outdated Python 3.5 ignore entries from the ansible-test sanity file for ansible-core 2.14

ansible-test 2.14 in el9 still checks for py35

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from tomjelinek as a code owner November 15, 2025 19:53
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the ansible-test ignore list to suppress outdated Python 3.5 import checks on ansible-core 2.14 by updating the .sanity-ansible-ignore-2.14.txt file accordingly.

File-Level Changes

Change Details Files
Suppress Python 3.5 import errors during ansible-test on ansible-core 2.14
  • Added patterns to ignore Python 3.5 import checks
  • Updated ignore list for ansible-core 2.14 sanity tests
.sanity-ansible-ignore-2.14.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (ae6805b) to head (4596b50).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   89.08%   90.92%   +1.84%     
==========================================
  Files          13       19       +6     
  Lines         980     1212     +232     
==========================================
+ Hits          873     1102     +229     
- Misses        107      110       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit 56a3e29 into linux-system-roles:main Nov 17, 2025
36 checks passed
@richm richm deleted the fix-ansible-test-issues branch November 17, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant