Skip to content

Conversation

@mirecheck
Copy link
Contributor

@mirecheck mirecheck commented Nov 19, 2025

Allow to set gitlab job tags by setting the gitlab CI/CD variable SHARED_RUNNER_TAG.

Summary by Sourcery

CI:

  • Replace hardcoded shared-podman tag with SHARED_RUNNER_TAG variable for tf_tests job

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces a hard-coded GitLab CI job tag with a dynamic tag sourced from the SHARED_RUNNER_TAG environment variable, allowing flexible runner assignment.

Flow diagram for GitLab CI job tag selection

flowchart TD
    Start["Start tf_tests job"] --> CheckVar["Check SHARED_RUNNER_TAG variable"]
    CheckVar --> AssignTag["Assign job tag from SHARED_RUNNER_TAG"]
    AssignTag --> RunnerSelect["GitLab selects runner matching tag"]
    RunnerSelect --> RunJob["Run tf_tests job"]
Loading

File-Level Changes

Change Details Files
Parameterize GitLab CI job runner tag
  • Replaced static "shared-podman" tag with "$SHARED_RUNNER_TAG"
  • Enabled tag customization via SHARED_RUNNER_TAG CI/CD variable
.gitlab-ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (ae6805b) to head (066608c).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   89.08%   90.92%   +1.84%     
==========================================
  Files          13       19       +6     
  Lines         980     1212     +232     
==========================================
+ Hits          873     1102     +229     
- Misses        107      110       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit b0c0071 into linux-system-roles:main Nov 19, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants