Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 5, 2025

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update QEMU integration test matrix to use Fedora 43 instead of Fedora 41 images.

CI:

  • Add Fedora 43 QEMU and container images with ansible-core 2.19 to the GitHub Actions integration test matrix.
  • Remove Fedora 41 QEMU and container images from the integration test matrix.

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from tomjelinek as a code owner December 5, 2025 20:38
@richm richm self-assigned this Dec 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the qemu-kvm integration test GitHub Actions workflow to start testing Fedora 43 (qemu and container, including bootc images) with newer Ansible core, while removing Fedora 41 test entries and obsolete comments.

File-Level Changes

Change Details Files
Update QEMU-based integration test matrix to include Fedora 43 and drop Fedora 41.
  • Add Fedora 43 image to the QEMU test matrix using env qemu-ansible-core-2.19.
  • Remove commented-out Fedora 41 QEMU entry and its associated bug note from the test matrix.
.github/workflows/qemu-kvm-integration-tests.yml
Update container-based integration test matrix to target Fedora 43 images and newer Ansible core version instead of Fedora 41.
  • Remove Fedora 41 and Fedora 41 bootc container entries from the matrix.
  • Add Fedora 43 and Fedora 43 bootc container entries using env container-ansible-core-2.19.
  • Retain Fedora 42 and Fedora 42 bootc container entries with existing env versions.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • For the container matrix, Fedora 42 still uses container-ansible-core-2.17 while Fedora 43 uses 2.19 (and both qemu Fedora 42/43 use 2.19); if this discrepancy isn’t intentional, consider aligning the ansible-core versions across qemu and container images for the same Fedora release.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the container matrix, Fedora 42 still uses `container-ansible-core-2.17` while Fedora 43 uses `2.19` (and both qemu Fedora 42/43 use `2.19`); if this discrepancy isn’t intentional, consider aligning the ansible-core versions across qemu and container images for the same Fedora release.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 6c467be into main Dec 5, 2025
43 checks passed
@richm richm deleted the ci-qemu-fedora-43 branch December 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants