-
Notifications
You must be signed in to change notification settings - Fork 24
ci: update test composes #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitLab CI test matrix to target newer RHEL composes for various COMPOSE_NAME presets. Flow diagram for updated GitLab CI compose variable selectionflowchart TD
start[Start CI job]
read[Read COMPOSE_NAME]
start --> read
read --> r10n{COMPOSE_NAME == Rhel10Next?}
r10n -->|yes| set_r10n[Set TF_COMPOSE=RHEL-10.2-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-10.2\nSet PCS_BRANCH=main\nSet PCS_ARTIFACTS_URL]
r10n -->|no| r10c{COMPOSE_NAME == Rhel10CurrentRelease?}
r10c -->|yes| set_r10c[Set TF_COMPOSE=RHEL-10.1-Nightly\nSet TMT_DISTRO=rhel-10.1\nSet PCS_BRANCH=main\nSet PCS_ARTIFACTS_URL]
r10c -->|no| r9n{COMPOSE_NAME == Rhel9Next?}
r9n -->|yes| set_r9n[Set TF_COMPOSE=RHEL-9.8.0-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-9.8\nSet PCS_BRANCH=pcs-0.11\nSet PCS_ARTIFACTS_URL]
r9n -->|no| r9c{COMPOSE_NAME == Rhel9CurrentRelease?}
r9c -->|yes| set_r9c[Set TF_COMPOSE=RHEL-9.7.0-Nightly\nSet TMT_DISTRO=rhel-9.7\nSet PCS_BRANCH=pcs-0.11\nSet PCS_ARTIFACTS_URL]
r9c -->|no| r8n{COMPOSE_NAME == Rhel8Next?}
r8n -->|yes| set_r8n[Set TF_COMPOSE=RHEL-8.10.0-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-8.10\nSet PCS_BRANCH=pcs-0.10\nSet PCS_ARTIFACTS_URL]
r8n -->|no| other[Use other CI defaults]
end_node[Run tests with selected compose]
set_r10n --> end_node
set_r10c --> end_node
set_r9n --> end_node
set_r9c --> end_node
set_r8n --> end_node
other --> end_node
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The RHEL version strings are duplicated across
TF_COMPOSEandTMT_DISTROfor each compose; consider centralizing them (e.g., via variables or YAML anchors) so future version bumps only need to be made in one place per release.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The RHEL version strings are duplicated across `TF_COMPOSE` and `TMT_DISTRO` for each compose; consider centralizing them (e.g., via variables or YAML anchors) so future version bumps only need to be made in one place per release.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 19 19
Lines 1212 1212
=======================================
Hits 1102 1102
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update test composes for GitLab CI.
Summary by Sourcery
CI: