Skip to content

Conversation

@mirecheck
Copy link
Contributor

@mirecheck mirecheck commented Dec 10, 2025

Update test composes for GitLab CI.

Summary by Sourcery

CI:

  • Refresh RHEL 8, 9, and 10 compose and distro versions used by GitLab CI test jobs to target newer nightly and point releases.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitLab CI test matrix to target newer RHEL composes for various COMPOSE_NAME presets.

Flow diagram for updated GitLab CI compose variable selection

flowchart TD
  start[Start CI job]
  read[Read COMPOSE_NAME]
  start --> read

  read --> r10n{COMPOSE_NAME == Rhel10Next?}
  r10n -->|yes| set_r10n[Set TF_COMPOSE=RHEL-10.2-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-10.2\nSet PCS_BRANCH=main\nSet PCS_ARTIFACTS_URL]
  r10n -->|no| r10c{COMPOSE_NAME == Rhel10CurrentRelease?}

  r10c -->|yes| set_r10c[Set TF_COMPOSE=RHEL-10.1-Nightly\nSet TMT_DISTRO=rhel-10.1\nSet PCS_BRANCH=main\nSet PCS_ARTIFACTS_URL]
  r10c -->|no| r9n{COMPOSE_NAME == Rhel9Next?}

  r9n -->|yes| set_r9n[Set TF_COMPOSE=RHEL-9.8.0-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-9.8\nSet PCS_BRANCH=pcs-0.11\nSet PCS_ARTIFACTS_URL]
  r9n -->|no| r9c{COMPOSE_NAME == Rhel9CurrentRelease?}

  r9c -->|yes| set_r9c[Set TF_COMPOSE=RHEL-9.7.0-Nightly\nSet TMT_DISTRO=rhel-9.7\nSet PCS_BRANCH=pcs-0.11\nSet PCS_ARTIFACTS_URL]
  r9c -->|no| r8n{COMPOSE_NAME == Rhel8Next?}

  r8n -->|yes| set_r8n[Set TF_COMPOSE=RHEL-8.10.0-Nightly\nSet TMT_DEVELOPMENT=true\nSet TMT_DISTRO=rhel-8.10\nSet PCS_BRANCH=pcs-0.10\nSet PCS_ARTIFACTS_URL]
  r8n -->|no| other[Use other CI defaults]

  end_node[Run tests with selected compose]
  set_r10n --> end_node
  set_r10c --> end_node
  set_r9n --> end_node
  set_r9c --> end_node
  set_r8n --> end_node
  other --> end_node
Loading

File-Level Changes

Change Details Files
Refresh RHEL 10 compose mappings for nightly and current-release test jobs.
  • Bump Rhel10Next TF_COMPOSE from generic RHEL-10-Nightly to RHEL-10.2-Nightly, aligning TMT_DISTRO to rhel-10.2
  • Update Rhel10CurrentRelease TF_COMPOSE from RHEL-10.0-Nightly to RHEL-10.1-Nightly, adjusting TMT_DISTRO to rhel-10.1
.gitlab-ci.yml
Refresh RHEL 9 compose mappings for nightly and current-release test jobs.
  • Bump Rhel9Next TF_COMPOSE from RHEL-9-Nightly to RHEL-9.8.0-Nightly, with TMT_DISTRO set to rhel-9.8
  • Update Rhel9CurrentRelease TF_COMPOSE from RHEL-9.6.0-Nightly to RHEL-9.7.0-Nightly, with TMT_DISTRO set to rhel-9.7
.gitlab-ci.yml
Refresh RHEL 8 compose mapping for nightly test job.
  • Bump Rhel8Next TF_COMPOSE from RHEL-8-Nightly to RHEL-8.10.0-Nightly, aligning TMT_DISTRO to rhel-8.10
.gitlab-ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The RHEL version strings are duplicated across TF_COMPOSE and TMT_DISTRO for each compose; consider centralizing them (e.g., via variables or YAML anchors) so future version bumps only need to be made in one place per release.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The RHEL version strings are duplicated across `TF_COMPOSE` and `TMT_DISTRO` for each compose; consider centralizing them (e.g., via variables or YAML anchors) so future version bumps only need to be made in one place per release.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (f58d15e) to head (618e030).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          19       19           
  Lines        1212     1212           
=======================================
  Hits         1102     1102           
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit 1bf7af6 into linux-system-roles:main Dec 10, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants