-
Notifications
You must be signed in to change notification settings - Fork 24
docs(changelog): version 1.28.0 [citest skip] #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update changelog and .README.html for version 1.28.0 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the changelog to document the 1.28.0 release, including a new feature and several CI-related maintenance changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `CHANGELOG.md:13` </location>
<code_context>
+
+### Other Changes
+
+- ci: define job tag by a gitlab variable (#333)
+- ci: introduce ansible-test ignore file for version 2.20 (#334)
+- ci: bump gha checkout from v5 to v6 (#336)
</code_context>
<issue_to_address>
**suggestion (typo):** Capitalize "GitLab" and consider slightly clearer wording for this entry
As a proper product name, this should be capitalized as "GitLab." Also consider rephrasing "define job tag by a GitLab variable" to "define job tag with a GitLab variable" or "using a GitLab variable" for more natural wording.
```suggestion
- ci: define job tag with a GitLab variable (#333)
```
</issue_to_address>
### Comment 2
<location> `CHANGELOG.md:16` </location>
<code_context>
+- ci: define job tag by a gitlab variable (#333)
+- ci: introduce ansible-test ignore file for version 2.20 (#334)
+- ci: bump gha checkout from v5 to v6 (#336)
+- ci: add qemu tests for Fedora 43, drop Fedora 41 (#337)
+- ci: update test composes (#338)
+
</code_context>
<issue_to_address>
**nitpick (typo):** Capitalize "QEMU" as a proper acronym
Please update "qemu" to "QEMU" here to match the standard capitalization of the tool’s name and avoid it reading like a typo.
Suggested implementation:
```
- ci: add QEMU tests for Fedora 43, drop Fedora 41 (#337)
```
There may be multiple references to “qemu” elsewhere in `CHANGELOG.md` (for other versions or sections) that are not shown in the snippet. Please search the whole file for the string `qemu` and update each instance to `QEMU` to keep the capitalization consistent throughout the changelog.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - ci: define job tag by a gitlab variable (#333) | ||
| - ci: introduce ansible-test ignore file for version 2.20 (#334) | ||
| - ci: bump gha checkout from v5 to v6 (#336) | ||
| - ci: add qemu tests for Fedora 43, drop Fedora 41 (#337) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Capitalize "QEMU" as a proper acronym
Please update "qemu" to "QEMU" here to match the standard capitalization of the tool’s name and avoid it reading like a typo.
Suggested implementation:
- ci: add QEMU tests for Fedora 43, drop Fedora 41 (#337)
There may be multiple references to “qemu” elsewhere in CHANGELOG.md (for other versions or sections) that are not shown in the snippet. Please search the whole file for the string qemu and update each instance to QEMU to keep the capitalization consistent throughout the changelog.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 19 19
Lines 1212 1212
=======================================
Hits 1102 1102
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update changelog and .README.html for version 1.28.0
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update changelog for the 1.28.0 release and document associated CI-related changes.
New Features:
CI: