Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 17, 2025

Update changelog and .README.html for version 1.28.0

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update changelog for the 1.28.0 release and document associated CI-related changes.

New Features:

  • Document support for fencing-watchdog-timeout in the 1.28.0 release.

CI:

  • Record updates to CI job tagging, ansible-test ignore configuration, GitHub Actions checkout version, and Fedora/QEMU test coverage for the 1.28.0 release.

Update changelog and .README.html for version 1.28.0

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from tomjelinek as a code owner December 17, 2025 16:07
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the changelog to document the 1.28.0 release, including a new feature and several CI-related maintenance changes.

File-Level Changes

Change Details Files
Document release 1.28.0 with new feature and CI-related updates in the changelog.
  • Add 1.28.0 release section with date and heading structure
  • List new feature: support for fencing-watchdog-timeout (feat: add support for fencing-watchdog-timeout #335) under a 'New Features' subsection
  • Add 'Other Changes' subsection enumerating CI and testing related updates: GitLab job tag variable, ansible-test ignore file for 2.20, GitHub Actions checkout bump, qemu tests matrix changes, and test compose updates
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `CHANGELOG.md:13` </location>
<code_context>
+
+### Other Changes
+
+- ci: define job tag by a gitlab variable (#333)
+- ci: introduce ansible-test ignore file for version 2.20 (#334)
+- ci: bump gha checkout from v5 to v6 (#336)
</code_context>

<issue_to_address>
**suggestion (typo):** Capitalize "GitLab" and consider slightly clearer wording for this entry

As a proper product name, this should be capitalized as "GitLab." Also consider rephrasing "define job tag by a GitLab variable" to "define job tag with a GitLab variable" or "using a GitLab variable" for more natural wording.

```suggestion
- ci: define job tag with a GitLab variable (#333)
```
</issue_to_address>

### Comment 2
<location> `CHANGELOG.md:16` </location>
<code_context>
+- ci: define job tag by a gitlab variable (#333)
+- ci: introduce ansible-test ignore file for version 2.20 (#334)
+- ci: bump gha checkout from v5 to v6 (#336)
+- ci: add qemu tests for Fedora 43, drop Fedora 41 (#337)
+- ci: update test composes (#338)
+
</code_context>

<issue_to_address>
**nitpick (typo):** Capitalize "QEMU" as a proper acronym

Please update "qemu" to "QEMU" here to match the standard capitalization of the tool’s name and avoid it reading like a typo.

Suggested implementation:

```
- ci: add QEMU tests for Fedora 43, drop Fedora 41 (#337)

```

There may be multiple references to “qemu” elsewhere in `CHANGELOG.md` (for other versions or sections) that are not shown in the snippet. Please search the whole file for the string `qemu` and update each instance to `QEMU` to keep the capitalization consistent throughout the changelog.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- ci: define job tag by a gitlab variable (#333)
- ci: introduce ansible-test ignore file for version 2.20 (#334)
- ci: bump gha checkout from v5 to v6 (#336)
- ci: add qemu tests for Fedora 43, drop Fedora 41 (#337)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Capitalize "QEMU" as a proper acronym

Please update "qemu" to "QEMU" here to match the standard capitalization of the tool’s name and avoid it reading like a typo.

Suggested implementation:

- ci: add QEMU tests for Fedora 43, drop Fedora 41 (#337)

There may be multiple references to “qemu” elsewhere in CHANGELOG.md (for other versions or sections) that are not shown in the snippet. Please search the whole file for the string qemu and update each instance to QEMU to keep the capitalization consistent throughout the changelog.

@richm richm merged commit 1643826 into linux-system-roles:main Dec 17, 2025
33 checks passed
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (f58d15e) to head (1ae68c7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          19       19           
  Lines        1212     1212           
=======================================
  Hits         1102     1102           
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant