ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Set Ansible fact injection off by default in CI to align tests with upcoming Ansible behavior.

CI:

• Configure qemu-kvm integration tests workflow to run with ANSIBLE_INJECT_FACT_VARS disabled.
• Pass SR_ANSIBLE_INJECT_FACT_VARS=false into the TFT workflow environment to ensure tests use fact variables explicitly.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI workflows to run Ansible with facts not injected as vars, aligning tests with Ansible 2.20+ behavior and enabling Terraform-based tests to pass through the new setting.

Flow diagram for CI env var propagation to Ansible

flowchart TD
  A[Start CI workflow tft] --> B[Initialize job terraform_functional_tests]
  B --> C[Set SR_ANSIBLE_INJECT_FACT_VARS=false in env block]
  C --> D[Launch Terraform-based test container]
  D --> E[Container inherits SR_ANSIBLE_INJECT_FACT_VARS=false]
  E --> F[Terraform invokes Ansible playbooks]
  F --> G[Ansible runs with facts not injected as vars]
  G --> H[Warnings or errors surface in CI if deprecated fact vars are used]
  H --> I[End CI workflow]

Loading

File-Level Changes

Change	Details	Files
Set ANSIBLE_INJECT_FACT_VARS=false in GitHub Actions CI workflows to enforce the new Ansible facts usage model during testing.	Add ANSIBLE_INJECT_FACT_VARS="false" to the environment of the qemu-kvm integration tests workflow so all tox-based CI runs use facts without var injection. Introduce SR_ANSIBLE_INJECT_FACT_VARS=false into the Terraform (tft) workflow’s SR_* variables string so that downstream tests executed via Terraform receive the new Ansible setting.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider standardizing how ANSIBLE_INJECT_FACT_VARS is passed between the qemu-kvm and tft workflows (e.g., using the same env var name and mechanism rather than ANSIBLE_INJECT_FACT_VARS in one and SR_ANSIBLE_INJECT_FACT_VARS embedded in a vars string in the other) to keep configuration consistent and easier to maintain.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider standardizing how `ANSIBLE_INJECT_FACT_VARS` is passed between the qemu-kvm and tft workflows (e.g., using the same env var name and mechanism rather than `ANSIBLE_INJECT_FACT_VARS` in one and `SR_ANSIBLE_INJECT_FACT_VARS` embedded in a vars string in the other) to keep configuration consistent and easier to maintain.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}