Skip to content

ci: Add an additional NIC for test purposes #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spetrosi merged 1 commit into from
Feb 7, 2025
Merged

ci: Add an additional NIC for test purposes #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ jobs:
tf_scope: private
api_key: ${{ secrets.TF_API_KEY_RH }}
update_pull_request_status: false
tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB" }'
tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB", "network": [{"type": "eth", "device-name": "eth0"}, {"type": "eth", "device-name": "eth1"}] }'
Copy link
Contributor

@richm richm Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangwen12year does this work?

Copy link
Collaborator Author

@spetrosi spetrosi Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tested it with Wen in TF and it seems to be working. Will see how TF action likes this syntax.

Copy link
Contributor

@liangwen12year liangwen12year Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pair-programmed with @spetrosi on a testing farm machine using the following command, and it works as expected.

ip a
nmcli c
nmcli d
ethtool -P eth0
cat  /sys/class/net/eth0/address
ethtool -P eth1
cat  /sys/class/net/eth1/address

Copy link
Contributor

@liangwen12year liangwen12year Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is a bit confusing, it is not adding two NICs , you only added 1 additional NIC, eth0 is still the default device for bridging the ssh connection between the control node and the managed host. Can you change the commit message to ci: Configure two NICs for testing purposes ?

tmt_plan_filter: "tag:general,network"

- name: Set final commit status
Expand Down
Loading