Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Sep 5, 2025

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure __bootc_validation is passed as a YAML boolean, upgrade tox-lsr in CI workflows, broaden failure detection for TF tests, and tidy contributing docs

CI:

  • Pass __bootc_validation as a YAML boolean literal in the extra-vars argument
  • Upgrade tox-lsr to version 3.11.1 across all CI workflows
  • Include cancelled runs alongside failures when detecting TF test workflow runs

Documentation:

  • Remove extra blank line in contributing.md

Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.

`-e "__bootc_validation: true"`

You can also use JSON format:

`-e '{"__bootc_validation": true}'`

but YAML is simpler in this case.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Sep 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates several CI workflow definitions to ensure __bootc_validation is passed as a YAML boolean, bumps the tox-lsr version across workflows, enhances failure detection in Terraform CI, and cleans up a minor markdown formatting issue.

Flow diagram for passing __bootc_validation as YAML boolean in CI

flowchart TD
  Start(["Start CI Workflow"]) --> SetVars["Set extra-vars: __bootc_validation: true (YAML boolean)"]
  SetVars --> RunTests["Run CI Tests (e.g., Terraform, Ansible)"]
  RunTests --> End(["End Workflow"])
Loading

File-Level Changes

Change Details Files
Pass __bootc_validation as a boolean in extra-vars
  • Wrap the __bootc_validation: true assignment in quotes to force YAML parsing
  • Replace the unquoted -e __bootc_validation=true usage in the qemu-kvm integration tests
.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency to version 3.11.1
  • Upgrade pip installation of tox-lsr from 3.11.0 to 3.11.1
  • Apply the version bump in all relevant workflow steps
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
Extend Terraform CI failure detection and add context
  • Add a comment explaining potential TF test cancellations
  • Update the jq filter to include both failed and cancelled workflow runs
.github/workflows/tft_citest_bad.yml
Remove extraneous blank line in contributing docs
  • Delete a stray empty line under the Running CI Tests Locally section
contributing.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm closed this Sep 5, 2025
@richm richm deleted the bootc_validation_bool branch September 5, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants