fix: cannot use community-general version 12 - no py27 and py36 support

[richm]

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
6.6.0 is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
11.x or later. Some roles like rhc explicitly require 6.6.0 or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own community_general_version in the role's
host_vars file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Enforce compatible community.general versions by pinning to <12 (with >=6.6.0) by default and allow per-role overrides, and standardize collection requirements file format across roles with a managed-by header and explicit name fields

Bug Fixes:

• Prevent installation of community.general v12 to retain Python 2.7/3.6 support

Enhancements:

• Pin default community.general version to the latest 11.x release with a 6.6.0 lower bound and enable override via host_vars
• Uniformly format collection-requirements.yml files by adding ‘name’ keys and a managed-by header

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enforces a version constraint on the community.general collection (>=6.6.0,<12.0.0) with a user-override variable, and unifies the structure of all collection-requirements.yml files by replacing the SPDX header with a managed-by notice and adopting a consistent ‘name:’ item syntax in both meta and test definitions.

ER diagram for collection requirements version constraints

erDiagram
COLLECTION_REQUIREMENT_FILE {
  managed_by_notice string
}
COLLECTION {
  name string
  version_constraint string
}
COLLECTION_REQUIREMENT_FILE ||--o{ COLLECTION : contains

Loading

Class diagram for standardized collection requirements structure

classDiagram
class CollectionRequirementFile {
  - managed_by_notice: string
  - collections: Collection[]
}
class Collection {
  - name: string
  - version: string (optional)
}
CollectionRequirementFile "1" *-- "many" Collection: contains

Loading

File-Level Changes

Change	Details	Files
Pin community.general collection version and expose override variable	Add version specifier “>=6.6.0,<12.0.0” for community.general Ensure installer defaults to the latest 11.x release Introduce a community_general_version variable for per-role host_vars overrides	meta/collection-requirements.yml tests/collection-requirements.yml
Standardize collection-requirements.yml formatting	Remove the SPDX license header Insert a “DO NOT EDIT – managed by linux-system-roles/.github” notice Convert list entries to dictionary items with a ‘name:’ key	meta/collection-requirements.yml tests/collection-requirements.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}