Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Sep 19, 2025

Use tox-lsr 3.12.0 for the new osbuild_config.yml feature for bootc and users
linux-system-roles/tox-lsr#211

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Upgrade tox-lsr to version 3.12.0 in all GitHub Actions workflows to enable the new osbuild_config.yml feature.

CI:

  • Bump tox-lsr installation to 3.12.0 in ansible-lint, ansible-managed-var-comment, and ansible-test workflows
  • Update tox-lsr version to 3.12.0 in the qemu-kvm-integration-tests workflow

Use tox-lsr 3.12.0 for the new osbuild_config.yml feature for bootc and users
linux-system-roles/tox-lsr#211

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from Jakuje as a code owner September 19, 2025 13:53
@richm richm self-assigned this Sep 19, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 19, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider centralizing the tox-lsr version in a single location or reusable workflow to avoid duplicating the bump across multiple CI files.
  • Verify that the new osbuild_config.yml feature is actually exercised in your CI jobs so you catch any regressions introduced by tox-lsr 3.12.0.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing the tox-lsr version in a single location or reusable workflow to avoid duplicating the bump across multiple CI files.
- Verify that the new osbuild_config.yml feature is actually exercised in your CI jobs so you catch any regressions introduced by tox-lsr 3.12.0.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit d864021 into main Sep 19, 2025
37 of 41 checks passed
@richm richm deleted the tox-lsr-3.12.0 branch September 19, 2025 18:40
@richm
Copy link
Contributor Author

richm commented Sep 19, 2025

failures will be fixed in a subsequent commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants