ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Add local CI testing instructions, enforce boolean pass-through of __bootc_validation, upgrade tox-lsr to 3.11.1 across CI workflows, and improve CI job resiliency.

CI:

• Pass __bootc_validation as a YAML boolean in qemu-kvm integration tests
• Upgrade tox-lsr from 3.11.0 to 3.11.1 in multiple GitHub Actions workflows
• Allow cancelled runs to be detected as failures in tft_citest_bad workflow

Documentation:

• Add a 'Running CI Tests Locally' section to contributing.md with steps for tox-lsr QEMU testing

[sourcery-ai]

Reviewer's Guide

This PR ensures __bootc_validation is passed as a YAML boolean (not string), aligns tox-lsr to v3.11.1 in all CI workflows, enhances TF CI failure detection to include cancellations, and adds documentation for running CI tests locally with tox-lsr and QEMU.

Flow diagram for improved TF CI failure detection

flowchart TD
  A["Start TF CI workflow"] --> B["Check for pending workflow"]
  B -->|If pending| C["Exit: Wait for finish"]
  B -->|If not pending| D["Query workflow runs for PR title"]
  D --> E["Select runs with conclusion 'failure' or 'cancelled'"]
  E --> F["Get RUN_ID"]
  F -->|If RUN_ID is null| G["Exit: Failed workflow not found"]
  F -->|If RUN_ID found| H["Continue with workflow"]

Loading

File-Level Changes

Change	Details	Files
Treat __bootc_validation as a boolean in CI invocations	Switch to -e "__bootc_validation: true" syntax Remove previous string-based flag usage	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr from 3.11.0 to 3.11.1 across CI workflows	Bump pip install URL to @3.11.1 in all workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Allow TF tests cancellation to be treated as failure in tft_citest_bad	Include .conclusion == "cancelled" in workflow_runs filter	.github/workflows/tft_citest_bad.yml
Add local CI testing guide for QEMU and tox-lsr	Introduce "Running CI Tests Locally" section in contributing.md Outline steps to install dependencies and run tox-lsr with QEMU	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}