ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Enable correct boolean handling for __bootc_validation and improve local CI testing documentation

Enhancements:

• Treat __bootc_validation extra-var as a YAML boolean rather than a string in the qemu-kvm workflow
• Include ‘cancelled’ conclusions when retrying failed TF tests in the tft_citest_bad workflow
• Upgrade tox-lsr version to 3.11.1 across CI workflows

Documentation:

• Add a ‘Running CI Tests Locally’ section to contributing.md with instructions for qemu-based testing

[sourcery-ai]

Reviewer's Guide

This PR updates CI workflows and documentation to pass the __bootc_validation flag as a true boolean, bump the tox-lsr dependency version, refine the TF test re-run logic, and add local CI test instructions in contributing.md.

Class diagram for updated tox-lsr dependency in CI workflows

classDiagram
  class CI_Workflow {
    +tox_lsr_version: string
    +install_tox_lsr()
  }
  CI_Workflow : tox_lsr_version = "3.11.1"
  CI_Workflow : install_tox_lsr() uses pip3
  CI_Workflow <|-- AnsibleLintWorkflow
  CI_Workflow <|-- ManagedVarCommentWorkflow
  class AnsibleLintWorkflow {
    +run_ansible_lint()
  }
  class ManagedVarCommentWorkflow {
    +run_ansible_plugin_scan()
  }

Loading

Flow diagram for passing __bootc_validation as boolean in CI

flowchart TD
  A["CI Workflow Start"] --> B["Set extra-vars"]
  B --> C["Pass __bootc_validation: true (YAML boolean)"]
  C --> D["Ansible Playbook Receives Boolean"]

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as a YAML boolean	Changed extra-vars syntax from -e __bootc_validation=true to -e "__bootc_validation: true"	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version to 3.11.1	Updated pip install URLs for tox-lsr from @3.11.0 to @3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Include cancelled runs in TF test failure detection	Adjusted jq filter to select conclusions == "failure" or "cancelled" Added comment explaining TF tests may be cancelled	.github/workflows/tft_citest_bad.yml
Add local CI test instructions	Document steps for setting up and running tox-lsr with QEMU locally Include prerequisites, installation commands, and sample commands	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider centralizing the tox-lsr version (3.11.1) in a shared variable or workflow anchor to avoid manually bumping it in each GitHub Actions file.
• The extensive QEMU CI test instructions in CONTRIBUTING.md are useful but could be offloaded to a separate include or collapsible section to keep the main doc concise.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider centralizing the tox-lsr version (3.11.1) in a shared variable or workflow anchor to avoid manually bumping it in each GitHub Actions file.
- The extensive QEMU CI test instructions in CONTRIBUTING.md are useful but could be offloaded to a separate include or collapsible section to keep the main doc concise.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}