Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 5, 2025

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI QEMU and container integration test matrix to target newer Fedora releases.

CI:

  • Add QEMU and container integration tests for Fedora 43 with ansible-core 2.19 images.
  • Remove Fedora 41 images from QEMU and container integration test jobs, including bootc variants.

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner December 5, 2025 20:39
@richm richm self-assigned this Dec 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the qemu-kvm GitHub Actions workflow to run integration tests on Fedora 43 (both QEMU and container/bootc variants) while removing Fedora 41 coverage and aligning Ansible core versions accordingly.

File-Level Changes

Change Details Files
Update QEMU integration test matrix to add Fedora 43 and drop Fedora 41 while adjusting associated Ansible core versions.
  • Extend QEMU test matrix to include a Fedora 43 image using ansible-core 2.19 alongside existing Fedora 42 coverage.
  • Remove commented-out Fedora 41 QEMU configuration that referenced an ansible/libdnf5 bug.
  • Update container test matrix to replace Fedora 41 images with Fedora 43 images and bump their ansible-core version from 2.17 to 2.19 where applicable.
  • Add Fedora 43 bootc container image entries with ansible-core 2.19 while retaining Fedora 42 bootc entries.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Now that Fedora 41 is fully dropped from the matrix, consider removing the stale commented-out Fedora 41 entry and its associated bug note to keep the workflow file tidy.
  • Fedora 42 images use ansible-core 2.19 for QEMU but 2.17 for container jobs, whereas Fedora 43 uses 2.19 for both; if this difference is intentional, it may be worth adding a brief inline comment to avoid confusion for future updates.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Now that Fedora 41 is fully dropped from the matrix, consider removing the stale commented-out Fedora 41 entry and its associated bug note to keep the workflow file tidy.
- Fedora 42 images use ansible-core 2.19 for QEMU but 2.17 for container jobs, whereas Fedora 43 uses 2.19 for both; if this difference is intentional, it may be worth adding a brief inline comment to avoid confusion for future updates.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 3321343 into main Dec 5, 2025
30 checks passed
@richm richm deleted the ci-qemu-fedora-43 branch December 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants