refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update Ansible fact usage to be compatible with INJECT_FACTS_AS_VARS=false and newer Ansible versions.

Enhancements:

• Replace deprecated implicit Ansible fact variables with explicit ansible_facts lookups in role variables and conditionals.

Documentation:

• Update README-ostree documentation to describe distro-version format using ansible_facts keys instead of deprecated fact variables.

Tests:

• Adjust test fixtures and comments to reference ansible_facts-based distribution fields instead of deprecated Ansible fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Ansible fact usage to be compatible with INJECT_FACTS_AS_VARS=false by replacing deprecated bare fact variables with lookups via ansible_facts in templates, conditionals, and documentation comments/tests.

File-Level Changes

Change	Details	Files
Refactor fact references in test playbook comments to use ansible_facts keys instead of deprecated bare fact variables.	Update commented example fact references from ansible_distribution and related variables to ansible_facts["distribution"] and corresponding keys. Ensure os family example uses ansible_facts["os_family"] in documentation comments within the test file.	tests/tests_include_vars_from_parent.yml
Align README documentation with new ansible_facts-based distro/version format.	Change documented DISTRO-VERSION format description to reference ansible_facts["distribution"] and ansible_facts["distribution_version"] instead of deprecated ansible_distribution variables.	README-ostree.md
Update role variables and conditionals to use ansible_facts['distribution'] for distro checks.	Replace ansible_distribution usage in __sudo_is_rh_distro with ansible_facts['distribution'] in RH distro test vars. Replace ansible_distribution usage in __sudo_is_rh_distro_fedora with ansible_facts['distribution'] in RH+Fedora distro test vars. Mirror the same replacements in the main vars file to keep runtime role logic consistent with tests.	tests/vars/rh_distros_vars.yml vars/main.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[richm]

[citest]

[sourcery-ai]

Hey - I've left some high level feedback:

• In tests/tests_include_vars_from_parent.yml you still use facts['distribution'] in the varfiles expression while the surrounding comments now refer to ansible_facts[...]; consider switching that to ansible_facts['distribution'] for consistency with the new access pattern and INJECT_FACTS_AS_VARS=false.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `tests/tests_include_vars_from_parent.yml` you still use `facts['distribution']` in the `varfiles` expression while the surrounding comments now refer to `ansible_facts[...]`; consider switching that to `ansible_facts['distribution']` for consistency with the new access pattern and `INJECT_FACTS_AS_VARS=false`.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d260a6b). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage        ?   52.31%           
=======================================
  Files           ?        1           
  Lines           ?      346           
  Branches        ?        0           
=======================================
  Hits            ?      181           
  Misses          ?      165           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.