fix: cannot use community-general version 12 - no py27 and py36 support #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
community.general version 12 has dropped support for py27 and py36 - ensure that the roles do not install/use this version - see ansible-collections/community.general#582 By default, installation will get the latest 11.x version. The lower bound `6.6.0` is an older version, but I don't want to restrict the ability of a user of a particular role to use an old version, rather than forcing them to use `11.x` or later. Some roles like `rhc` explicitly require `6.6.0` or later - I think this is a reasonable lower bound for all roles.If a role needs a different version, the role can define its own `community_general_version` in the role's `host_vars` file in .github. Standardize file format across all roles for consistency and ease of updating This update may remove the SPDX license information from the file - this is ok - the role/project already has a license, this file is trivial, and many requirements files do not have the license header anyway. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582
By default, installation will get the latest 11.x version. The lower bound
6.6.0is an older version, but I don't want to restrict the ability of a userof a particular role to use an old version, rather than forcing them to use
11.xor later. Some roles likerhcexplicitly require6.6.0or later - Ithink this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own
community_general_versionin the role'shost_varsfile in .github.Standardize file format across all roles for consistency and ease of updating
This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Prevent usage of community.general collection version 12 by adding version constraints, set default range to >=6.6.0,<12 while allowing role-specific overrides, and standardize the format of meta/collection-requirements.yml across all roles.
Bug Fixes:
Enhancements: