ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr v3.11.1, pass __bootc_validation as a boolean, enhance failure detection, and add local testing documentation

Enhancements:

• Include cancelled runs when detecting failed TF tests in tft_citest_bad workflow

CI:

• Bump tox-lsr dependency to v3.11.1 in multiple GitHub workflows
• Pass __bootc_validation as a YAML boolean in qemu-kvm-integration-tests

Documentation:

• Add instructions for running CI tests locally with tox-lsr and QEMU

[sourcery-ai]

Reviewer's Guide

This PR refines CI behavior by passing __bootc_validation as a YAML boolean, updates tox-lsr to v3.11.1 across all CI workflows, enhances Terraform CI failure detection to include cancellations, and adds instructions for running CI tests locally.

Sequence diagram for improved Terraform CI failure detection

sequenceDiagram
  participant Workflow as "tft_citest_bad.yml"
  participant GitHub as "GitHub API"
  participant User as actor "User"
  User->>Workflow: Trigger workflow
  Workflow->>GitHub: Query workflow runs for PR title
  GitHub-->>Workflow: Return workflow runs
  Workflow->>Workflow: Check for runs with conclusion == "failure" or "cancelled"
  alt Found failed/cancelled run
    Workflow->>User: Notify about failed/cancelled workflow
  else No failed/cancelled run
    Workflow->>User: Notify workflow not found, exit
  end

Loading

Class diagram for passing __bootc_validation as boolean in CI

classDiagram
  class CI_Workflow {
    +run_tests()
    +pass_extra_vars()
  }
  class ExtraVars {
    +__bootc_validation: bool
  }
  CI_Workflow --> ExtraVars: uses
  ExtraVars : __bootc_validation set as boolean (true)

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as YAML boolean	Change extra-vars syntax to -e "__bootc_validation: true"	.github/workflows/qemu-kvm-integration-tests.yml
Update tox-lsr version to 3.11.1 in CI workflows	Bump pip3 install commands from @3.11.0 to @3.11.1 in multiple workflows Update pip install in python-unit-test to use v3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Extend GH API filter for cancelled TF runs	Add comment explaining TF tests may be cancelled Modify jq filter to include conclusion == "cancelled"	.github/workflows/tft_citest_bad.yml
Add instructions for running CI tests locally	Introduce "Running CI Tests Locally" section Document steps for using tox-lsr with qemu, including prerequisites and example command	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}