Skip to content

Conversation

@martinpitt
Copy link
Contributor

@martinpitt martinpitt commented Jun 14, 2025

Cause: The test used a temporary variable ansible_managed, but that is a "magic" string constant. Ansible 2.19 does not permit assigning to it any more.

Consequence: Tests failed with Ansible 2.19.

Fix: Rename the variable.


This should fix the current Ansible 2.19 failure

Summary by Sourcery

Bug Fixes:

  • Rename test variable ansible_managed to __ansible_managed to avoid setting a magic Ansible variable and fix test failures on Ansible 2.19.

Cause: The test used a temporary variable `ansible_managed`, but that is
a "magic" string constant. Ansible 2.19 does not permit assigning to it
any more.

Consequence: Tests failed with Ansible 2.19.

Fix: Rename the variable.
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 14, 2025

Reviewer's Guide

Renamed the reserved ansible_managed test variable to __ansible_managed in the header‐checking task to prevent assignment failures under Ansible 2.19.

File-Level Changes

Change Details Files
Avoid assignment to the magic ansible_managed variable by renaming it
  • Update assertion to check __ansible_managed instead of ansible_managed
  • Rename variable definition to __ansible_managed
tests/tasks/check_header.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@martinpitt
Copy link
Contributor Author

[citest]

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martinpitt - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 253f558 into linux-system-roles:main Jun 14, 2025
27 checks passed
@martinpitt martinpitt deleted the a219 branch June 14, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants