ci: rollout several recent changes to CI testing

[richm]

• Pass in a YAML true value as __bootc_validation: true using
  the --extra-vars option to ensure that __bootc_validation is
  treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

• Use tox-lsr version 3.11.1

• Ensure the citest bad comment works when the test was cancelled in
  addition to the failure case.

• Update contributing.md documentation

• Update number of nodes to use in testing farm, if needed

• remove unnecessary ansible-lint skips

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Roll out recent CI improvements by upgrading dependencies, refining test execution flags, handling cancelled test runs, cleaning up lint skips, and enhancing documentation for local testing

Bug Fixes:

• Recognize cancelled test runs in the citest bad comment workflow alongside failures

Enhancements:

• Upgrade tox-lsr dependency to version 3.11.1 across CI workflows
• Pass __bootc_validation as a YAML boolean instead of a string in CI test commands

CI:

• Remove unnecessary ansible-lint skips in CI configurations

Documentation:

• Add local CI testing instructions using tox-lsr and QEMU to contributing.md

[sourcery-ai]

Reviewer's Guide

This PR refines CI workflows and documentation by ensuring correct boolean handling for __bootc_validation, upgrading tox-lsr to 3.11.1 across jobs, extending the citest bad comment check to capture cancelled runs, and adding detailed local CI testing instructions to contributing.md.

Flow diagram for citest bad comment workflow with cancelled runs

flowchart TD
  Start(["Start workflow"]) --> CheckPending["Check if workflow is still running"]
  CheckPending -->|Still running| Exit1["Exit: Wait for finish"]
  CheckPending -->|Not running| FindRun["Find failed or cancelled run"]
  FindRun -->|Run found| Continue["Continue workflow"]
  FindRun -->|Run not found| Exit2["Exit: Failed workflow not found"]

Loading

File-Level Changes

Change	Details	Files
Treat __bootc_validation as YAML boolean via extra-vars	Changed extra-vars syntax from -e __bootc_validation=true to -e "__bootc_validation: true"	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version to 3.11.1	Updated pip3 install URL to version 3.11.1 in CI workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Allow cancelled runs in citest bad comment	Extended jq filter to include conclusion == cancelled	.github/workflows/tft_citest_bad.yml
Add local CI testing documentation	Inserted 'Running CI Tests Locally' section with qemu and tox-lsr setup steps	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}