ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Improve CI workflows and documentation by passing bootc validation as a true boolean, upgrading tox-lsr, and adding local QEMU testing instructions

CI:

• Upgrade tox-lsr to v3.11.1 across GitHub workflows
• Pass __bootc_validation as a YAML boolean in the qemu-kvm integration tests
• Include cancelled runs as failures in the TFT CI retry logic

Documentation:

• Add instructions for running CI tests locally with tox-lsr and QEMU in contributing.md

[sourcery-ai]

Reviewer's Guide

This PR refines CI configuration by ensuring the __bootc_validation flag is passed as a YAML boolean, bumps the tox-lsr version across workflows, enriches local CI testing documentation, and improves handling of cancelled Terraform test runs.

Class diagram for passing __bootc_validation as boolean in CI

classDiagram
  class CI_ExtraVars {
    +__bootc_validation: bool
  }
  class CI_Workflow {
    +run_tests(extra_vars: dict)
  }
  CI_Workflow --> CI_ExtraVars: uses

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency in CI workflows	Upgrade pip3 install reference from v3.11.0 to v3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Pass __bootc_validation as a boolean	Replace -e __bootc_validation=true with -e "__bootc_validation: true" using YAML syntax	.github/workflows/qemu-kvm-integration-tests.yml
Enhance local CI test documentation	Add steps for running qemu-based CI tests with tox-lsr to contributing guidelines	contributing.md
Improve Terraform test failure handling	Update jq filter to include cancelled runs and add explanatory comment	.github/workflows/tft_citest_bad.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider splitting the large contributing.md additions into a separate PR to keep the boolean CI change focused.
• To avoid future drift when bumping tox-lsr, consider extracting the version string into a reusable CI variable or template.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider splitting the large contributing.md additions into a separate PR to keep the boolean CI change focused.
- To avoid future drift when bumping tox-lsr, consider extracting the version string into a reusable CI variable or template.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}