Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 5, 2025

tests_default_wrapper.yml should use local connection for the nested
test if the test is using local connection

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Adjust the inventory template to explicitly set local connection parameters when running nested tests with a local connection, and retain the existing host variable mappings for non-local connections.

Bug Fixes:

  • Ensure the default test wrapper uses a local connection and localhost for nested tests when ansible_connection is set to local

Enhancements:

  • Modify tests/inventory.yaml.j2 to conditionally emit ansible_connection and ansible_host settings for local hosts

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 5, 2025

Reviewer's Guide

Modifies the inventory.yaml.j2 template to detect when the play is running with a local connection and, in that case, emit explicit local connection settings instead of the default hostvars loop; otherwise preserves the original behavior in an else block.

File-Level Changes

Change Details Files
Introduce Jinja conditional around the existing hostvars loop
  • Insert {% if ansible_connection == "local" %}/{% else %}/{% endif %} to branch on connection type
  • Wrap the original for-loop and its internal if within the else branch
  • Adjust indentation of the for-loop and its {% if %}/{% endif %} tags
tests/inventory.yaml.j2
Define explicit local connection settings in the local branch
  • Add ansible_connection: local
  • Add ansible_host: localhost
tests/inventory.yaml.j2

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Aug 5, 2025

[citest]

tests_default_wrapper.yml should use local connection for the nested
test if the test is using local connection

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the test-default-wrapper branch from 1d8d489 to 8833dc5 Compare August 5, 2025 15:40
@richm
Copy link
Contributor Author

richm commented Aug 5, 2025

[citest]

@richm richm merged commit e221a54 into linux-system-roles:main Aug 5, 2025
7 checks passed
@richm richm deleted the test-default-wrapper branch August 5, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant