ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use correct boolean formatting and upgraded tox-lsr, improve tft failure handling, and extend documentation with local testing instructions

CI:

• Bump tox-lsr dependency from v3.11.0 to v3.11.1 across GitHub workflows
• Pass __bootc_validation as a YAML boolean in the qemu-kvm integration tests
• Include cancelled runs when selecting failed workflows in tft_citest_bad

Documentation:

• Add instructions for running CI tests locally with tox-lsr and QEMU in the contributing guide

[sourcery-ai]

Reviewer's Guide

This PR ensures the CI flag __bootc_validation is passed as a native boolean, updates tox-lsr to 3.11.1 across workflows, expands failure detection in tft tests to include cancellations, and adds local CI testing instructions to the CONTRIBUTING guide.

Sequence diagram for passing __bootc_validation as boolean in CI

sequenceDiagram
  participant CI as "CI Workflow"
  participant tox as "tox-lsr"
  participant ansible as "Ansible"
  CI->>tox: Run tox-lsr with --extra-vars
  tox->>ansible: Pass __bootc_validation: true (boolean)
  ansible->>ansible: Treat __bootc_validation as boolean

Loading

Sequence diagram for expanded failure detection in tft tests

sequenceDiagram
  participant CI as "CI Workflow"
  participant GH as "GitHub API"
  CI->>GH: Query workflow runs for tft.yml
  GH-->>CI: Return runs with conclusion
  CI->>CI: Select runs with conclusion == failure or cancelled
  CI->>CI: Handle failed/cancelled workflow

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as a true boolean via YAML syntax	Replaced -e __bootc_validation=true with -e "__bootc_validation: true" in the qemu-kvm integration workflow	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency from 3.11.0 to 3.11.1 in CI workflows	Updated pip install URL version to 3.11.1 in qemu-kvm, ansible-lint, ansible-managed-var-comment, and ansible-test workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Enhance TF test failure detection to include cancelled runs	Modified jq filter to select runs with conclusion of failure or cancelled Added explanatory comment about TF test behavior	.github/workflows/tft_citest_bad.yml
Add local CI testing instructions to CONTRIBUTING guide	Created 'Running CI Tests Locally' section with tox-lsr qemu setup steps Detailed installation steps for dependencies and sample test commands	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}