ci: rollout several recent changes to CI testing

[richm]

• Pass in a YAML true value as __bootc_validation: true using
  the --extra-vars option to ensure that __bootc_validation is
  treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

• Use tox-lsr version 3.11.1

• Ensure the citest bad comment works when the test was cancelled in
  addition to the failure case.

• Update contributing.md documentation

• Update number of nodes to use in testing farm, if needed

• remove unnecessary ansible-lint skips

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Refine CI testing by upgrading tox-lsr, ensuring proper boolean handling, enhancing workflows, and updating documentation

Bug Fixes:

• Fix CITest bad-comment action to catch cancelled test runs in addition to failures

Enhancements:

• Upgrade tox-lsr to version 3.11.1 across GitHub workflows
• Adjust CI workflows to pass __bootc_validation as a YAML boolean in extra-vars
• Extend CITest workflow to detect cancelled runs alongside failures

Documentation:

• Add a local CI testing guide using tox-lsr with QEMU to contributing.md

[sourcery-ai]

Reviewer's Guide

This PR refines CI workflows by upgrading tox-lsr to 3.11.1 across all tests, changing the __bootc_validation extra-vars flag to use a YAML boolean, extending the contributing guide with local CI instructions, and updating the citest bad-comment workflow to account for cancelled runs.

Sequence diagram for citest bad-comment workflow handling cancelled runs

sequenceDiagram
    participant GitHub Actions
    participant "gh api"
    participant jq
    participant User
    User->>GitHub Actions: Trigger citest bad-comment workflow
    GitHub Actions->>"gh api": Request workflow runs for PR
    "gh api"->>jq: Filter runs by display_title and conclusion
    jq-->>GitHub Actions: Return run ID for failure or cancelled
    GitHub Actions->>User: Notify if failed/cancelled workflow found or exit

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr to version 3.11.1	Updated pip3 install commands to use tox-lsr@3.11.1 in CI workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Pass __bootc_validation as a YAML boolean	Replaced extra-vars flag to -e "__bootc_validation: true" to ensure CLI treats it as a boolean	.github/workflows/qemu-kvm-integration-tests.yml
Include cancelled runs in citest bad-comment workflow	Expanded jq filter to select runs with conclusion 'failure' or 'cancelled' Added a comment noting TF tests cancellation as a valid failure trigger	.github/workflows/tft_citest_bad.yml
Enhance contributing.md with local CI test guidance	Added a 'Running CI Tests Locally' section detailing tox-lsr and QEMU setup steps	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}