-
Notifications
You must be signed in to change notification settings - Fork 15
ci: Add Fedora 42; use tox-lsr 3.9.0; use lsr-report-errors for qemu tests #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tests Add Fedora 42 to testing farm test matrix, drop Fedora 40 Use tox-lsr 3.9.0 for the `--lsr-report-errors-url` argument. Add the argument `--lsr-report-errors-url DEFAULT` to the qemu test so that the errors will be written to the output log. This uses the output callback https://github.com/linux-system-roles/auto-maintenance/blob/main/callback_plugins/lsr_report_errors.py Use the check_logs.py script https://github.com/linux-system-roles/auto-maintenance/blob/main/check_logs.py with the `--github-action-format` argument to format the errors in a github action friendly manner. Rename the log files `-FAIL.log` or `-SUCCESS.log` depending on status. This is compatible with the way the testing farm log files are named, and makes it easy to tell if a test passed or failed from the log file name. Upload README.html as artifacts of the build_docs job for debugging Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR upgrades the tox-lsr dependency in CI workflows, expands the testing farm matrix by adding Fedora 42 (and dropping Fedora 40), enhances QEMU test logging and error reporting by adding lsr-report-errors-url, renaming logs, and using check_logs.py, and adds a README.html artifact upload step in the docs build job. Sequence Diagram: Enhanced QEMU Test Error ReportingsequenceDiagram
participant GHA_Runner as GitHub Actions Runner
participant QEMU_Test as QEMU Test
participant LSR_Callback as lsr_report_errors.py (Callback)
participant Log_Checker as check_logs.py (Script)
participant Log_File as Log File
GHA_Runner->>QEMU_Test: Execute with --lsr-report-errors-url DEFAULT
activate QEMU_Test
alt Errors Occur
QEMU_Test->>LSR_Callback: Triggered by Ansible
activate LSR_Callback
LSR_Callback-->>Log_File: Write error details to output log
deactivate LSR_Callback
end
deactivate QEMU_Test
GHA_Runner->>Log_Checker: Execute with --github-action-format
activate Log_Checker
Log_Checker->>Log_File: Read log
Log_Checker-->>Log_File: Rename log (e.g., -FAIL.log)
Log_Checker-->>GHA_Runner: Output formatted errors for GitHub UI
deactivate Log_Checker
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richm - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add Fedora 42 to testing farm test matrix, drop Fedora 40
Use tox-lsr 3.9.0 for the
--lsr-report-errors-urlargument.Add the argument
--lsr-report-errors-url DEFAULTto the qemu test so thatthe errors will be written to the output log. This uses the output callback
https://github.com/linux-system-roles/auto-maintenance/blob/main/callback_plugins/lsr_report_errors.py
Use the check_logs.py script
https://github.com/linux-system-roles/auto-maintenance/blob/main/check_logs.py
with the
--github-action-formatargument to format the errorsin a github action friendly manner.
Rename the log files
-FAIL.logor-SUCCESS.logdepending on status.This is compatible with the way the testing farm log files are named, and
makes it easy to tell if a test passed or failed from the log file name.
Upload README.html as artifacts of the build_docs job for debugging
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI to test Fedora-42 and bump tox-lsr to 3.9.0, and improve QEMU test logging and error reporting, uploading documentation artifacts.
Enhancements:
--lsr-report-errors-url DEFAULTto QEMU testsCI:
Documentation: