-
Notifications
You must be signed in to change notification settings - Fork 106
fix: update OBEX file transfer notification timeout #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the timeout value from receiveFileNeverTimeout to receiveFileNotifyTimeout for OBEX file transfer progress notifications. This fixes an issue where notifications would remain indefinitely without proper timeout handling, potentially causing stale notifications to persist in the system. The new timeout ensures notifications are automatically dismissed after a reasonable period, improving user experience and system resource management. fix: 更新 OBEX 文件传输通知超时设置 将 OBEX 文件传输进度通知的超时值从 receiveFileNeverTimeout 更改为 receiveFileNotifyTimeout。这修复了通知可能无限期保留而缺乏适当超时处理的 问题,避免了陈旧通知在系统中持续存在。新的超时设置确保通知在合理时间后自 动消失,改善了用户体验和系统资源管理。 PMS: BUG-304197
Reviewer's guide (collapsed on small PRs)Reviewer's GuideChanged the OBEX file transfer notification timeout setting to use receiveFileNotifyTimeout instead of receiveFileNeverTimeout, ensuring notifications automatically time out and improving resource management. Class diagram for OBEX file transfer notification timeout updateclassDiagram
class obexAgent {
+notifyProgress(notify, replaceID, actions, hints)
}
class notifications {
+Notifications
}
obexAgent --> notifications: uses
class receiveFileNeverTimeout
class receiveFileNotifyTimeout
obexAgent ..> receiveFileNotifyTimeout: uses (updated)
obexAgent ..x receiveFileNeverTimeout: no longer used
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review我来对这个diff进行仔细审查:
改进建议:
总体来说,这是一个好的改动,提高了代码的健壮性和可维护性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Changed the timeout value from receiveFileNeverTimeout to receiveFileNotifyTimeout for OBEX file transfer progress notifications. This fixes an issue where notifications would remain indefinitely without proper timeout handling, potentially causing stale notifications to persist in the system. The new timeout ensures notifications are automatically dismissed after a reasonable period, improving user experience and system resource management.
fix: 更新 OBEX 文件传输通知超时设置
将 OBEX 文件传输进度通知的超时值从 receiveFileNeverTimeout 更改为
receiveFileNotifyTimeout。这修复了通知可能无限期保留而缺乏适当超时处理的
问题,避免了陈旧通知在系统中持续存在。新的超时设置确保通知在合理时间后自
动消失,改善了用户体验和系统资源管理。
PMS: BUG-304197
Summary by Sourcery
Replace the indefinite timeout with a notify-specific timeout for OBEX file transfer progress notifications to ensure they are auto-dismissed after a reasonable period.
Bug Fixes:
Enhancements: