fix: extend custom timezone mapping list

[wyu71]

• Updated customTimeZoneList to include additional timezone entries.

Log: extend custom timezone mapping list
pms: BUG-338797

Summary by Sourcery

Bug Fixes:

• Include Asia/Urumqi in the custom timezone list to ensure it maps to Asia/Shanghai

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request updates the SetTimezone handler to extend its hard-coded customTimeZoneList by adding the Asia/Urumqi entry, ensuring that selecting this zone will map to Asia/Shanghai like the other custom zones.

Class diagram for updated SetTimezone logic

classDiagram
    class Manager {
        +SetTimezone(sender, timezone, message) *dbus.Error
    }

Loading

Flow diagram for custom timezone mapping update

flowchart TD
    A["User selects timezone"] --> B["Is timezone in customTimeZoneList?"]
    B -->|Yes| C["Map to Asia/Shanghai"]
    B -->|No| D["Use selected timezone"]

Loading

File-Level Changes

Change	Details	Files
Extended custom timezone mapping list	Added 'Asia/Urumqi' to the customTimeZoneList array	system/timedate1/manager_ifc.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来对这个diff进行审查：

1. 语法逻辑：

• 代码修改在语法上是正确的，只是在customTimeZoneList切片中添加了一个新的时区字符串"Asia/Urumqi"
• 逻辑保持一致，当用户选择列表中的任何时区时，都会统一链接到"Asia/Shanghai"时区

2. 代码质量：

• 优点：
  • 代码结构清晰，注释说明了处理逻辑
  • 使用了strv.Strv的Contains方法进行判断，代码简洁
• 改进建议：
  • 建议将customTimeZoneList定义为包级别的常量，因为这是一个固定的时区列表
  • 可以考虑添加更详细的注释，说明为什么这些时区需要统一链接到上海时区

3. 代码性能：

• 当前的实现性能是合理的，使用Contains方法的时间复杂度是O(n)
• 如果时区列表会继续增长，可以考虑使用map来优化查找性能，将时间复杂度降低到O(1)

4. 代码安全：

• 没有发现明显的安全问题
• 建议添加时区字符串的有效性验证，防止无效的时区输入

改进建议的代码示例：

// 包级别常量
var customTimeZoneMap = map[string]bool{
    "Asia/Chengdu": true,
    "Asia/Beijing": true,
    "Asia/Nanjing": true,
    "Asia/Wuhan": true,
    "Asia/Xian": true,
    "Asia/Urumqi": true,
}

func (m *Manager) SetTimezone(sender dbus.Sender, timezone, message string) *dbus.Error {
    // 验证时区有效性
    if timezone == "" {
        return dbusutil.ToError(errors.New("empty timezone"))
    }
    
    if err := m.checkAuthorization(sender, managerPolicyActionId); err != nil {
        return dbusutil.ToError(err)
    }
    
    // 使用map优化查找性能
    if customTimeZoneMap[timezone] {
        timezone = "Asia/Shanghai"
    }
    // 其余代码保持不变...
}

这个改进版本：

1. 使用map替代slice提高查找性能
2. 添加了基本的时区有效性验证
3. 将时区列表定义为包级别常量，提高代码可维护性
4. 保持了原有的业务逻辑不变

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, wyu71

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wyu71]

/forcemerge

[deepin-bot]

This pr force merged! (status: unstable)