-
Notifications
You must be signed in to change notification settings - Fork 106
fix: update notification center D-Bus interface paths #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the D-Bus service name and object path for the notification center widget control. The system now uses the new org.deepin.dde.shell service instead of the deprecated org.deepin.dde.Widgets service, and the notification center is accessed through the correct /org/deepin/dde/ shell/notification/center path. This change ensures compatibility with the latest DDE shell architecture where the notification center functionality has been moved from the standalone Widgets service to the integrated shell service. Influence: 1. Test notification center show/hide functionality through gesture actions 2. Verify D-Bus service availability and response times 3. Test error handling when notification center is unavailable 4. Verify the change works across different DDE shell versions 5. Test concurrent access to notification center controls fix: 更新通知中心 D-Bus 接口路径 更新了通知中心部件控制的 D-Bus 服务名称和对象路径。系统现在使用新的 org.deepin.dde.shell 服务替代已弃用的 org.deepin.dde.Widgets 服务,并通 过正确的 /org/deepin/dde/shell/notification/center 路径访问通知中心。 此更改确保与最新的 DDE shell 架构兼容,其中通知中心功能已从独立的 Widgets 服务移至集成的 shell 服务。 PMS: BUG-315125 Influence: 1. 通过手势操作测试通知中心的显示/隐藏功能 2. 验证 D-Bus 服务的可用性和响应时间 3. 测试通知中心不可用时的错误处理 4. 验证更改在不同 DDE shell 版本中的兼容性 5. 测试通知中心控制的并发访问
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR migrates the notification center widget control to the updated D-Bus interface by replacing the deprecated Widgets service with the new org.deepin.dde.shell service, updating the object path and method calls accordingly. Sequence diagram for updated D-Bus notification center controlsequenceDiagram
participant GestureManager
participant SessionBus
participant "org.deepin.dde.shell"
GestureManager->>SessionBus: Connect to D-Bus
SessionBus->>"org.deepin.dde.shell": Access /org/deepin/dde/shell/notification/center
alt Show notification center
GestureManager->>"org.deepin.dde.shell": Call notification.center.Show
else Hide notification center
GestureManager->>"org.deepin.dde.shell": Call notification.center.Hide
end
"org.deepin.dde.shell"-->>GestureManager: Return result or error
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider extracting the D-Bus service names and object paths into constants to avoid duplication and typos.
- Add a fallback to the deprecated org.deepin.dde.Widgets service when the new path fails to maintain compatibility with older DDE shell versions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the D-Bus service names and object paths into constants to avoid duplication and typos.
- Add a fallback to the deprecated org.deepin.dde.Widgets service when the new path fails to maintain compatibility with older DDE shell versions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Updated the D-Bus service name and object path for the notification center widget control. The system now uses the new org.deepin.dde.shell service instead of the deprecated org.deepin.dde.Widgets service, and the notification center is accessed through the correct /org/deepin/dde/ shell/notification/center path.
This change ensures compatibility with the latest DDE shell architecture where the notification center functionality has been moved from the standalone Widgets service to the integrated shell service.
Influence:
fix: 更新通知中心 D-Bus 接口路径
更新了通知中心部件控制的 D-Bus 服务名称和对象路径。系统现在使用新的
org.deepin.dde.shell 服务替代已弃用的 org.deepin.dde.Widgets 服务,并通 过正确的 /org/deepin/dde/shell/notification/center 路径访问通知中心。
此更改确保与最新的 DDE shell 架构兼容,其中通知中心功能已从独立的
Widgets 服务移至集成的 shell 服务。
PMS: BUG-315125
Influence:
Summary by Sourcery
Bug Fixes: