Skip to content

Conversation

@fly602
Copy link
Contributor

@fly602 fly602 commented Oct 30, 2025

Updated the D-Bus service name and object path for the notification center widget control. The system now uses the new org.deepin.dde.shell service instead of the deprecated org.deepin.dde.Widgets service, and the notification center is accessed through the correct /org/deepin/dde/ shell/notification/center path.

This change ensures compatibility with the latest DDE shell architecture where the notification center functionality has been moved from the standalone Widgets service to the integrated shell service.

Influence:

  1. Test notification center show/hide functionality through gesture actions
  2. Verify D-Bus service availability and response times
  3. Test error handling when notification center is unavailable
  4. Verify the change works across different DDE shell versions
  5. Test concurrent access to notification center controls

fix: 更新通知中心 D-Bus 接口路径

更新了通知中心部件控制的 D-Bus 服务名称和对象路径。系统现在使用新的
org.deepin.dde.shell 服务替代已弃用的 org.deepin.dde.Widgets 服务,并通 过正确的 /org/deepin/dde/shell/notification/center 路径访问通知中心。

此更改确保与最新的 DDE shell 架构兼容,其中通知中心功能已从独立的
Widgets 服务移至集成的 shell 服务。

PMS: BUG-315125
Influence:

  1. 通过手势操作测试通知中心的显示/隐藏功能
  2. 验证 D-Bus 服务的可用性和响应时间
  3. 测试通知中心不可用时的错误处理
  4. 验证更改在不同 DDE shell 版本中的兼容性
  5. 测试通知中心控制的并发访问

Summary by Sourcery

Bug Fixes:

  • Switch notification center D-Bus service to org.deepin.dde.shell and update object path and Show/Hide method calls for compatibility with the new DDE shell architecture

Updated the D-Bus service name and object path for the notification
center widget control. The system now uses the new org.deepin.dde.shell
service instead of the deprecated org.deepin.dde.Widgets service, and
the notification center is accessed through the correct /org/deepin/dde/
shell/notification/center path.

This change ensures compatibility with the latest DDE shell architecture
where the notification center functionality has been moved from the
standalone Widgets service to the integrated shell service.

Influence:
1. Test notification center show/hide functionality through gesture
actions
2. Verify D-Bus service availability and response times
3. Test error handling when notification center is unavailable
4. Verify the change works across different DDE shell versions
5. Test concurrent access to notification center controls

fix: 更新通知中心 D-Bus 接口路径

更新了通知中心部件控制的 D-Bus 服务名称和对象路径。系统现在使用新的
org.deepin.dde.shell 服务替代已弃用的 org.deepin.dde.Widgets 服务,并通
过正确的 /org/deepin/dde/shell/notification/center 路径访问通知中心。

此更改确保与最新的 DDE shell 架构兼容,其中通知中心功能已从独立的
Widgets 服务移至集成的 shell 服务。

PMS: BUG-315125
Influence:
1. 通过手势操作测试通知中心的显示/隐藏功能
2. 验证 D-Bus 服务的可用性和响应时间
3. 测试通知中心不可用时的错误处理
4. 验证更改在不同 DDE shell 版本中的兼容性
5. 测试通知中心控制的并发访问
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR migrates the notification center widget control to the updated D-Bus interface by replacing the deprecated Widgets service with the new org.deepin.dde.shell service, updating the object path and method calls accordingly.

Sequence diagram for updated D-Bus notification center control

sequenceDiagram
participant GestureManager
participant SessionBus
participant "org.deepin.dde.shell"

GestureManager->>SessionBus: Connect to D-Bus
SessionBus->>"org.deepin.dde.shell": Access /org/deepin/dde/shell/notification/center
alt Show notification center
    GestureManager->>"org.deepin.dde.shell": Call notification.center.Show
else Hide notification center
    GestureManager->>"org.deepin.dde.shell": Call notification.center.Hide
end
"org.deepin.dde.shell"-->>GestureManager: Return result or error
Loading

File-Level Changes

Change Details Files
Migrated notification center widget control to the new D-Bus interface
  • Updated sessionBus.Object instantiation to use org.deepin.dde.shell and /org/deepin/dde/shell/notification/center
  • Replaced Show and Hide method calls with org.deepin.dde.shell.notification.center.Show and ...Hide
gesture1/manager.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider extracting the D-Bus service names and object paths into constants to avoid duplication and typos.
  • Add a fallback to the deprecated org.deepin.dde.Widgets service when the new path fails to maintain compatibility with older DDE shell versions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the D-Bus service names and object paths into constants to avoid duplication and typos.
- Add a fallback to the deprecated org.deepin.dde.Widgets service when the new path fails to maintain compatibility with older DDE shell versions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 merged commit d3504a1 into linuxdeepin:master Oct 30, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants