chore: remove powermanager module #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR eliminates the redundant powermanager module by removing its references from build, initialization, service, and D-Bus configs, and deleting all module source files, consolidating power management under the existing power1 implementation. Class diagram for removed powermanager moduleclassDiagram
class PowerManager {
+Shutdown()
+Reboot()
+Suspend()
+Hibernate()
+IsVirtualMachine()
}
class PowerManagerDaemon {
+Start()
+Stop()
+HandleDBusRequests()
}
PowerManagerDaemon --> PowerManager
%% All powermanager classes and their methods are removed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Verify that all existing consumers referencing the old powermanager D-Bus interface have been migrated to the power1 interface to avoid broken integrations.
- Double-check that no socket activation units or service files for power_manager1 remain in your systemd configurations after this removal.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify that all existing consumers referencing the old powermanager D-Bus interface have been migrated to the power1 interface to avoid broken integrations.
- Double-check that no socket activation units or service files for power_manager1 remain in your systemd configurations after this removal.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Removed the powermanager module as it appears to be redundant with the existing power1 module. The changes include: 1. Removed powermanager from TEST list in Makefile 2. Removed powermanager import from main.go 3. Deleted D-Bus configuration file for powermanager service 4. Removed powermanager-related comments from systemd service file 5. Completely removed all powermanager source code files including daemon.go, manager.go, and utility files The powermanager module provided similar functionality to the power1 module, including system power state checks (shutdown, reboot, suspend, hibernate) and virtual machine detection. This removal simplifies the codebase by eliminating duplicate functionality. Influence: 1. Verify system power management functions still work correctly through power1 module 2. Test shutdown, reboot, suspend, and hibernate capabilities 3. Confirm no regression in virtual machine detection 4. Check D-Bus service availability for power-related operations 5. Validate system daemon starts without powermanager dependencies chore: 移除powermanager模块 移除powermanager模块，因为它与现有的power1模块功能重复。具体变更包括： 1. 从Makefile的TEST列表中移除powermanager 2. 从main.go中移除powermanager导入 3. 删除powermanager服务的D-Bus配置文件 4. 从systemd服务文件中移除powermanager相关注释 5. 完全删除所有powermanager源代码文件，包括daemon.go、manager.go和工具 文件 powermanager模块提供的功能与power1模块相似，包括系统电源状态检查（关机、 重启、待机、休眠）和虚拟机检测。此次移除通过消除重复功能简化了代码库。 Influence: 1. 验证通过power1模块的系统电源管理功能仍正常工作 2. 测试关机、重启、待机和休眠功能 3. 确认虚拟机检测功能无回归问题 4. 检查电源相关操作的D-Bus服务可用性 5. 验证系统守护进程在没有powermanager依赖的情况下正常启动
fly602
force-pushed
the
rm-powermanager
branch
from
e7ab4f1 to
df101d3
Compare
deepin pr auto review这是一个关于删除 power_manager1 模块的代码变更审查。我来分析一下这个变更：
改进建议：
总的来说，这个变更看起来是合理的，但需要确保系统的电源管理功能不会受到影响。建议进行全面的测试验证，并确保有适当的文档说明这个变更。 |
mhduiy
approved these changes
Nov 6, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the powermanager module as it appears to be redundant with the existing power1 module. The changes include:
The powermanager module provided similar functionality to the power1 module, including system power state checks (shutdown, reboot, suspend, hibernate) and virtual machine detection. This removal simplifies the codebase by eliminating duplicate functionality.
Influence:
chore: 移除powermanager模块
移除powermanager模块，因为它与现有的power1模块功能重复。具体变更包括：
powermanager模块提供的功能与power1模块相似，包括系统电源状态检查（关机、
重启、待机、休眠）和虚拟机检测。此次移除通过消除重复功能简化了代码库。
Influence:
Summary by Sourcery
Remove the redundant powermanager module and clean up related configurations and code references
Enhancements:
Build:
Deployment:
Chores: