Skip to content

Conversation

@yixinshark
Copy link
Contributor

as title

Log: Time text language should not changes with time zone
Bug: https://pms.uniontech.com/bug-view-287217.html

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • Q_UNUSED(locale); 可能会导致误解,因为函数参数未被使用
  • m_shortTimeFormat.replace(QRegExp("a?p", Qt::CaseInsensitive), "AP"); 使用了 QRegExp,建议使用 QRegularExpression 以提高性能和可读性

是否建议立即修改:

}

// "Ap"/"aP"->"AP"
m_shortTimeFormat.replace(QRegExp("a?p", Qt::CaseInsensitive), "AP");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该找谁设置了这种Ap吧,不然还有其它显示的地方会有这种问题,

Copy link
Contributor Author

@yixinshark yixinshark Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从Qt6.3开始,可以兼容Ap,aP这种,此项目是qt5的。新版的控制中心可以做兼容。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 7ff64c2 into linuxdeepin:master Nov 27, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants