sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#3

Summary by Sourcery

Enhancements:

• Modify geometry update logic in fullscreenbackground to support a new compilation configuration (ENABLE_DSS_SNIPE)

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 在条件编译宏 ENABLE_DSS_SNIPE 下，updateGeometry() 被无条件调用，可能导致不必要的屏幕更新。
• 缺少对 ENABLE_DSS_SNIPE 宏定义的说明或注释，不利于理解代码意图。

是否建议立即修改:

• 是

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using Q_OS_LINUX instead of ENABLE_DSS_SNIPE if this is specific to Linux.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a conditional compilation block that determines whether updateGeometry() is always called or only called when there are multiple screens. This change is controlled by the ENABLE_DSS_SNIPE macro. When ENABLE_DSS_SNIPE is defined, updateGeometry() is always called; otherwise, it's only called when there are multiple screens.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a conditional compilation block to control whether updateGeometry() is always called or only called when there are multiple screens.	Wrapped the conditional call to updateGeometry() within an #ifndef ENABLE_DSS_SNIPE block. Added an #else block to unconditionally call updateGeometry() when ENABLE_DSS_SNIPE is defined.	src/widgets/fullscreenbackground.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment