Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Jun 9, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#12

Summary by Sourcery

Synchronize with upstream dde-session-shell to ensure UI elements in SFAWidget are refreshed on show and include new ignore and history files.

Enhancements:

  • Invoke updateSpaceItem and updateBlurEffectGeometry when SFAWidget is shown

Chores:

  • Add .cursorindexingignore file
  • Add .specstory/.gitignore file
  • Add specstory history markdown file

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#12
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 9, 2025

Reviewer's Guide

This PR brings in upstream synchronization from linuxdeepin/dde-session-shell by augmenting the SFAWidget showEvent logic to update UI components reliably and by adding new ignore and specstory history files for tooling consistency.

Sequence diagram for new UI update calls in SFAWidget::showEvent

sequenceDiagram
    participant SFAWidget
    participant QTimer

    Note over SFAWidget: New calls within SFAWidget::showEvent()
    SFAWidget->>SFAWidget: updateSpaceItem()
    SFAWidget->>QTimer: singleShot(0, this, &SFAWidget::updateBlurEffectGeometry)
    QTimer-->>SFAWidget: updateBlurEffectGeometry()
Loading

Updated class diagram for SFAWidget

classDiagram
  class SFAWidget {
    +void showEvent(QShowEvent *event)
    +void updateSpaceItem()
    +void updateBlurEffectGeometry()
    +void updateFocus()
  }
  note for SFAWidget "showEvent() is modified.
Calls to updateSpaceItem() and QTimer::singleShot() for updateBlurEffectGeometry() are new additions within this method."
Loading

File-Level Changes

Change Details Files
Enhanced SFAWidget showEvent to ensure proper UI updates
  • Invoke updateSpaceItem at the start of showEvent
  • Schedule updateBlurEffectGeometry via QTimer::singleShot
  • Maintain the existing updateFocus scheduling
src/session-widgets/sfa_widget.cpp
Add ignore configuration and specstory history documentation
  • Introduce .cursorindexingignore to exclude cursor indexing files
  • Add .specstory/.gitignore for specstory output
  • Include a new specstory history markdown detailing recent fixes
.cursorindexingignore
.specstory/.gitignore
.specstory/history/2025-06-09_03-08-…bug.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yixinshark yixinshark closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants