-
Notifications
You must be signed in to change notification settings - Fork 57
sync: from linuxdeepin/dde-session-shell #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#12
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR brings in upstream synchronization from linuxdeepin/dde-session-shell by augmenting the SFAWidget showEvent logic to update UI components reliably and by adding new ignore and specstory history files for tooling consistency. Sequence diagram for new UI update calls in SFAWidget::showEventsequenceDiagram
participant SFAWidget
participant QTimer
Note over SFAWidget: New calls within SFAWidget::showEvent()
SFAWidget->>SFAWidget: updateSpaceItem()
SFAWidget->>QTimer: singleShot(0, this, &SFAWidget::updateBlurEffectGeometry)
QTimer-->>SFAWidget: updateBlurEffectGeometry()
Updated class diagram for SFAWidgetclassDiagram
class SFAWidget {
+void showEvent(QShowEvent *event)
+void updateSpaceItem()
+void updateBlurEffectGeometry()
+void updateFocus()
}
note for SFAWidget "showEvent() is modified.
Calls to updateSpaceItem() and QTimer::singleShot() for updateBlurEffectGeometry() are new additions within this method."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#12
Summary by Sourcery
Synchronize with upstream dde-session-shell to ensure UI elements in SFAWidget are refreshed on show and include new ignore and history files.
Enhancements:
Chores: