-
Notifications
You must be signed in to change notification settings - Fork 57
sync: from linuxdeepin/dde-session-shell #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#13
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideAdds UI update calls in the SFAWidget showEvent to refresh space items and recalculate blur effect geometry when the widget appears. Sequence Diagram: New Interactions in SFAWidget.showEventsequenceDiagram
participant Caller
participant SFAW as SFAWidget
participant QT as QTimer
Caller->>SFAW: showEvent(event)
activate SFAW
SFAW->>SFAW: updateSpaceItem() // New interaction
SFAW->>QT: singleShot(0, &SFAWidget::updateBlurEffectGeometry) // New interaction
deactivate SFAW
QT-->>SFAW: updateBlurEffectGeometry() // Async callback resulting from new interaction
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#13
Summary by Sourcery
Sync source from linuxdeepin/dde-session-shell and enhance SFAWidget::showEvent to update space and blur effect geometry
Enhancements: