sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#15

Summary by Sourcery

Enhancements:

• Adjust DLineEditEx load slider animation start offset from -40 to -10 and end offset from width() to width()-50

[sourcery-ai]

Reviewer's Guide

Synchronized upstream changes, modifying the DLineEditEx load slider animation range.

Sequence Diagram: DLineEditEx Animation Parameter Update

sequenceDiagram
  participant DLineEditEx
  participant m_animation as QPropertyAnimation

  DLineEditEx->>m_animation: setStartValue(QPoint(0 - 10, 0))
  DLineEditEx->>m_animation: setEndValue(QPoint(width() - 50, 0))

Loading

Updated Class Diagram for DLineEditEx

classDiagram
  class DLineEditEx {
    +startAnimation() : void
  }

Loading

File-Level Changes

Change	Details	Files
Adjusted the load slider's animation start and end positions	Changed start offset from -40 to -10 Changed end position to width - 50 instead of full width	src/widgets/dlineeditex.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Avoid hard-coded offsets for animation start/end

Calculate the offsets using m_loadSlider->width() to ensure correct animation positions if the slider size changes.

Suggested change

	m_loadSlider->show();
	m_loadSlider->resize(40, height());
	m_animation->setStartValue(QPoint(0 - 40, 0));
	m_animation->setEndValue(QPoint(width(), 0));
	m_animation->setStartValue(QPoint(0 - 10 , 0));
	m_animation->setEndValue(QPoint(width() - 50, 0));
	m_animation->start();
	m_loadSlider->show();
	m_loadSlider->resize(40, height());
	int sliderWidth = m_loadSlider->width();
	m_animation->setStartValue(QPoint(0 - sliderWidth, 0));
	m_animation->setEndValue(QPoint(width() - sliderWidth, 0));
	m_animation->start();

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 代码中使用了三元运算符来处理动画结束位置的X坐标，但逻辑可以简化。
• 注释应该更详细地解释为什么动画块距离右侧的距离是10px。

是否建议立即修改:

• 是

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment