-
Notifications
You must be signed in to change notification settings - Fork 57
sync: from linuxdeepin/dde-session-shell #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR imports and synchronizes TS translation files for four Spanish regional variants from the linuxdeepin/dde-session-shell repository, adding new skeleton translation files and seeding partial translations in the Mexican Spanish (es_MX) variant. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:
- Many translation entries are still marked as "unfinished"—please coordinate with the localization team or integrate translation memory tools to complete them before merging.
- The UDCP MFA strings in
UdcpMFALoginWidgetare still in Chinese (e.g. “发送验证码”); please normalize the source to English or provide the appropriate Spanish translations. - Several plural-form entries have empty
<numerusform>blocks—fill out each form for the Spanish variants to ensure correct pluralization at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Many translation entries are still marked as "unfinished"—please coordinate with the localization team or integrate translation memory tools to complete them before merging.
- The UDCP MFA strings in `UdcpMFALoginWidget` are still in Chinese (e.g. “发送验证码”); please normalize the source to English or provide the appropriate Spanish translations.
- Several plural-form entries have empty `<numerusform>` blocks—fill out each form for the Spanish variants to ensure correct pluralization at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review代码审查意见:
以上是针对代码翻译部分的审查意见,其他部分的代码审查需要根据具体实现来进行分析。 |
|
TAG Bot New tag: 6.0.42 |
|
@deepin-ci-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dc7502e to
1d324da
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#17
Summary by Sourcery
Synchronize translation resources from upstream by adding region-specific Spanish TS files for dde-session-shell.
Enhancements: