Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Jul 7, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#18

Summary by Sourcery

Sync source from linuxdeepin/dde-session-shell, refactor date formatting in SNIPE mode, and add regional Spanish translations.

Enhancements:

  • Replace longDateFormat with shortDateFormat in time and center-top widgets, updating method signatures, config keys, and date display logic to include the weekday.

Documentation:

  • Add Spanish translation files for regional variants: es_419, es_AR, es_CL, and es_MX.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#18
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 7, 2025

Reviewer's Guide

This pull request synchronizes upstream changes by refactoring date format handling in DSS_SNIPE-enabled widgets—renaming the longDateFormat parameter to shortDateFormat, updating logic to combine date and weekday—and adds a set of Spanish translation files for multiple locales.

Class diagram for TimeWidget date format refactor

classDiagram
    class TimeWidget {
        +QString m_shortTimeFormat
        +QString m_shortDateFormat
        +void updateLocale(const QString &locale, const QString &shortTimeFormat = "", const QString &shortDateFormat = "")
        +void refreshTime()
    }
Loading

Class diagram for CenterTopWidget date format update

classDiagram
    class CenterTopWidget {
        +void onUserRegionFormatValueChanged(const QDBusMessage &dbusMessage)
        +void updateUserDateTimeFormat()
        -static const QString shortDateFormatKey
        -static const QString shortTimeFormatKey
        -static const QString localeNameKey
        +TimeWidget* m_timeWidget
    }
    CenterTopWidget --> TimeWidget
Loading

File-Level Changes

Change Details Files
Refactor DSS_SNIPE date format handling
  • Rename updateLocale parameter and member from longDateFormat to shortDateFormat
  • Change condition checks to use shortDateFormat instead of longDateFormat
  • Concatenate shortDateFormat and weekday for dateLabel output
  • Update config key and D-Bus handling in CenterTopWidget to use shortDateFormatKey
src/widgets/timewidget.cpp
src/widgets/timewidget.h
src/widgets/centertopwidget.cpp
Add Spanish translation files
  • Introduce .ts files for es_419, es_AR, es_CL, es_MX locales
  • Populate contexts and message entries for authentication and session UI strings
translations/dde-session-shell_es_419.ts
translations/dde-session-shell_es_AR.ts
translations/dde-session-shell_es_CL.ts
translations/dde-session-shell_es_MX.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit ef77705 into master Jul 10, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants