-
Notifications
You must be signed in to change notification settings - Fork 57
sync: from linuxdeepin/dde-session-shell #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#18
Reviewer's GuideThis pull request synchronizes upstream changes by refactoring date format handling in DSS_SNIPE-enabled widgets—renaming the longDateFormat parameter to shortDateFormat, updating logic to combine date and weekday—and adds a set of Spanish translation files for multiple locales. Class diagram for TimeWidget date format refactorclassDiagram
class TimeWidget {
+QString m_shortTimeFormat
+QString m_shortDateFormat
+void updateLocale(const QString &locale, const QString &shortTimeFormat = "", const QString &shortDateFormat = "")
+void refreshTime()
}
Class diagram for CenterTopWidget date format updateclassDiagram
class CenterTopWidget {
+void onUserRegionFormatValueChanged(const QDBusMessage &dbusMessage)
+void updateUserDateTimeFormat()
-static const QString shortDateFormatKey
-static const QString shortTimeFormatKey
-static const QString localeNameKey
+TimeWidget* m_timeWidget
}
CenterTopWidget --> TimeWidget
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#18
Summary by Sourcery
Sync source from linuxdeepin/dde-session-shell, refactor date formatting in SNIPE mode, and add regional Spanish translations.
Enhancements:
longDateFormatwithshortDateFormatin time and center-top widgets, updating method signatures, config keys, and date display logic to include the weekday.Documentation: