Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Jul 7, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#19

Summary by Sourcery

Synchronize source files from linuxdeepin/dde-session-shell, add regional Spanish translations, and adjust the load slider rendering.

Enhancements:

  • Adjust LoadSlider to fill the full widget height when painting the gradient.
  • Add initial Spanish translation files for Latin American and region-specific locales (es_419, es_AR, es_CL, es_MX).

Chores:

  • Sync source files from the upstream linuxdeepin/dde-session-shell repository.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 7, 2025

Reviewer's Guide

This PR syncs upstream changes by applying a minor UI painting fix and adding Spanish locale translation templates for four regions.

Class diagram for LoadSlider paintEvent change

classDiagram
    class LoadSlider {
        +paintEvent(QPaintEvent *event)
    }
    %% The paintEvent method was modified to change the rectangle fill area from (0,1,width(),height()-2) to (0,0,width(),height())
Loading

File-Level Changes

Change Details Files
Fix LoadSlider paintEvent gradient fill rectangle
  • Changed fillRect y-coordinate from 1 to 0
  • Adjusted height parameter to use full widget height
src/widgets/dlineeditex.cpp
Add Spanish locale translation templates
  • Imported empty translation file for es_419
  • Imported empty translation file for es_AR
  • Imported empty translation file for es_CL
  • Imported empty translation file for es_MX
translations/dde-session-shell_es_419.ts
translations/dde-session-shell_es_AR.ts
translations/dde-session-shell_es_CL.ts
translations/dde-session-shell_es_MX.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

代码审查意见:

  1. dlineeditex.cpp文件中,paintEvent函数的修改可能会影响滑块的外观。原代码中,填充区域的高度是height() - 2,而修改后的代码是height(),这可能会导致滑块在垂直方向上扩展,从而改变其外观。建议确认这一修改是否符合设计要求。

  2. dss-session-shell_es_MX.ts文件中,AuthPassword上下文的Wrong Password消息的翻译已经完成,但AuthSingle上下文的Reset PasswordForgot password?消息的翻译还未完成。建议完成所有未完成的翻译。

  3. dss-session-shell_es_MX.ts文件中,ShutdownWidget上下文的Shut down消息的翻译已经完成,但RebootSuspendHibernateLockLog outSwitch userSwitch systemUpdate and Shut DownUpdate and Reboot消息的翻译还未完成。建议完成所有未完成的翻译。

  4. dss-session-shell_es_MX.ts文件中,UdcpMFALoginWidget上下文的发送验证码请输入手机号请输入验证码获取验证码消息的翻译还未完成。建议完成所有未完成的翻译。

  5. dss-session-shell_es_MX.ts文件中,UpdateCompleteWidget上下文的View LogsUpdates successfulYour computer will reboot soon %1Your computer will be turned off soon %1消息的翻译还未完成。建议完成所有未完成的翻译。

  6. dss-session-shell_es_MX.ts文件中,UpdateLogWidget上下文的Hide Logs消息的翻译还未完成。建议完成所有未完成的翻译。

  7. dss-session-shell_es_MX.ts文件中,UpdateModel上下文的Update failedUnknown errorBackup failedDependency errorRebootShut DownUnable to perform system backup. If you continue the updates, you cannot roll back to the old system later.Insufficient disk space. Please clean up your disk and try again.DPKG errorBack Up AgainAbortProceed to UpdateFailed to connect to backup services. Please check and retry again.Failed to connect to update services. Please check and retry again.消息的翻译还未完成。建议完成所有未完成的翻译。

  8. dss-session-shell_es_MX.ts文件中,UpdatePrepareWidget上下文的Preparing for updates…消息的翻译还未完成。建议完成所有未完成的翻译。

  9. dss-session-shell_es_MX.ts文件中,UpdateProgressWidget上下文的Do not force a shutdown or power off when installing updates. Otherwise, your system may be damaged.消息的翻译还未完成。建议完成所有未完成的翻译。

  10. dss-session-shell_es_MX.ts文件中,UpdateWorker上下文的UpdatePlease plug in and then install updates.消息的翻译还未完成。建议完成所有未完成的翻译。

  11. dss-session-shell_es_MX.ts文件中,WarningContent上下文的The programs are preventing the computer from shutting down, and forcing shut down may cause data loss.To close the program, click Cancel, and then close the program.The programs are preventing the computer from reboot, and forcing reboot may cause data loss.The programs are preventing the computer from suspend, and forcing suspend may cause data loss.The programs are preventing the computer from hibernate, and forcing hibernate may cause data loss.The programs are preventing the computer from log out, and forcing log out may cause data loss.Shut downRebootSuspendHibernateLog outAre you sure you want to shut down?Are you sure you want to reboot?Are you sure you want to log out?Update and Shut DownUpdate and RebootClosing the programs and shutting down, please wait...Closing the programs and rebooting, please wait...Closing the programs and logging out, please wait...消息的翻译还未完成。建议完成所有未完成的翻译。

  12. dss-session-shell_es_MX.ts文件中,dss::module::AssistLoginWidget上下文的Automatic login消息的翻译还未完成。建议完成所有未完成的翻译。

  13. dss-session-shell_es_MX.ts文件中,dss::module::NetworkModule上下文的Turn onTurn off消息的翻译还未完成。建议完成所有未完成的翻译。

以上是本次代码审查的反馈,希望对您有所帮助。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#19
@yixinshark yixinshark merged commit 1d324da into master Jul 10, 2025
25 of 28 checks passed
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants