Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Jul 8, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#20

Summary by Sourcery

Sync changes from upstream linuxdeepin/dde-session-shell: refresh license headers, include new license texts, and add comprehensive Spanish locale translations.

New Features:

  • Add Spanish translation files for es_419, es_AR, es_CL, and es_MX locales.

Enhancements:

  • Update SPDX headers and license identifiers across source files.
  • Add LICENSES entries for LGPL-2.0-or-later, LGPL-3.0-or-later, and MIT.

Build:

  • Update .reuse/dep5 metadata and .project configuration to match upstream.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 8, 2025

Reviewer's Guide

This PR syncs updates from linuxdeepin/dde-session-shell by refreshing SPDX headers to update years and switch to GPL-3.0-or-later, adding missing license document files, and importing new Spanish translation TS resources for multiple locales.

Flow diagram for the addition of new Spanish translation resources

flowchart TD
    A[Start] --> B{Sync from upstream}
    B --> C[Add dde-session-shell_es_419.ts]
    B --> D[Add dde-session-shell_es_AR.ts]
    B --> E[Add dde-session-shell_es_CL.ts]
    B --> F[Add dde-session-shell_es_MX.ts]
    C --> G[Translations available for es_419]
    D --> H[Translations available for es_AR]
    E --> I[Translations available for es_CL]
    F --> J[Translations available for es_MX]
Loading

File-Level Changes

Change Details Files
Update SPDX headers and license identifiers
  • Add/refresh SPDX copyright headers with updated year ranges
  • Change license tags from LGPL to GPL-3.0-or-later
src/pam-inhibit-autologin/pam_inhibit_autologin.c
src/session-widgets/fullmanagedauthwidget.h
src/widgets/popupwindow.cpp
src/widgets/popupwindow.h
Add missing license text files
  • Include LGPL-2.0-or-later license text
  • Include LGPL-3.0-or-later license text
  • Include MIT license text
LICENSES/LGPL-2.0-or-later.txt
LICENSES/LGPL-3.0-or-later.txt
LICENSES/MIT.txt
Import Spanish translation resources
  • Add translation TS for es_419
  • Add translation TS for es_AR
  • Add translation TS for es_CL
  • Add translation TS for es_MX
translations/dde-session-shell_es_419.ts
translations/dde-session-shell_es_AR.ts
translations/dde-session-shell_es_CL.ts
translations/dde-session-shell_es_MX.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

代码审查意见:

  1. .project文件中,"type": "homebrew" | "opensource",这一行语法错误,应该使用逗号分隔两个选项,而不是使用竖线。建议修改为"type": ["homebrew", "opensource"],

  2. .reuse/dep5文件中,# cmake部分缺少对cmake文件的描述,建议补充描述信息。

  3. LICENSES/GPL-3.0-or-later.txt文件中,版权声明中的URL已经更新为https://fsf.org/https://www.gnu.org/licenses/,建议确认这些URL是否正确。

  4. LICENSES/LGPL-2.0-or-later.txtLICENSES/LGPL-3.0-or-later.txt文件是新添加的,建议确认这些许可证文件是否适用于项目。

  5. LICENSES/MIT.txt文件是新添加的,建议确认这个许可证文件是否适用于项目。

  6. plugins/examples/login-plugins/login-udcp/qss/udcp_mfa_login_widget.qss文件中,版权声明已经添加,但是缺少对版权持有者的描述。

  7. src/pam-inhibit-autologin/pam_inhibit_autologin.c文件中,版权声明已经添加,但是缺少对版权持有者的描述。

  8. src/session-widgets/fullmanagedauthwidget.hsrc/widgets/abstractfullbackgroundinterface.hsrc/widgets/popupwindow.cppsrc/widgets/popupwindow.h文件中,版权声明已经添加,但是缺少对版权持有者的描述。

  9. translations/dde-session-shell_es_419.tstranslations/dde-session-shell_es_AR.tstranslations/dde-session-shell_es_CL.tstranslations/dde-session-shell_es_MX.ts文件中,部分翻译内容为type="unfinished",表示未完成翻译,建议完成翻译。

  10. 整体来看,代码审查没有发现明显的语法错误,但是存在一些版权声明和许可证文件需要确认和补充的地方。建议在合并代码前,确认这些文件的正确性和完整性。

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#20
@yixinshark yixinshark merged commit 15e906b into master Jul 10, 2025
26 of 28 checks passed
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants