Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Jul 10, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#23

Summary by Sourcery

Sync source from linuxdeepin/dde-session-shell: update icon pixmap usage and include new Spanish translation files

Enhancements:

  • Simplify icon pixmap scaling by removing device pixel ratio factor

Documentation:

  • Add Spanish translation files for es_419, es_AR, es_CL, and es_MX locales

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#23
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 10, 2025

Reviewer's Guide

This PR syncs upstream changes from linuxdeepin/dde-session-shell by simplifying icon pixmap handling in the InhibitWarnView and adding initial Spanish translation templates for several regional variants.

Class diagram for InhibitWarnView icon pixmap handling update

classDiagram
    class InhibitWarnView {
        +void initUi()
        - setNormalPixmap(QPixmap) for m_acceptBtn: now uses iconSize only
        - setHoverPixmap(QPixmap) for m_acceptBtn: now uses iconSize only
        - setNormalPixmap(QPixmap) for m_cancelBtn: now uses iconSize only
        - setHoverPixmap(QPixmap) for m_cancelBtn: now uses iconSize only
    }
    InhibitWarnView --> AcceptButton : m_acceptBtn
    InhibitWarnView --> CancelButton : m_cancelBtn
    class AcceptButton {
        +setNormalPixmap(QPixmap)
        +setHoverPixmap(QPixmap)
    }
    class CancelButton {
        +setNormalPixmap(QPixmap)
        +setHoverPixmap(QPixmap)
    }
Loading

File-Level Changes

Change Details Files
Simplify icon pixmap sizing in InhibitWarnView
  • Removed devicePixelRatioF multiplies from pixmap calls
  • Updated setNormalPixmap and setHoverPixmap to use iconSize directly
src/widgets/inhibitwarnview.cpp
Add Spanish translation TS files for multiple regions
  • Introduced new translation templates for es_419, es_AR, es_CL, es_MX
  • Populated contexts for authentication, session and system UI elements
  • Included partial translations in es_MX with most entries marked unfinished
translations/dde-session-shell_es_419.ts
translations/dde-session-shell_es_AR.ts
translations/dde-session-shell_es_CL.ts
translations/dde-session-shell_es_MX.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Jul 11, 2025

TAG Bot

New tag: 6.0.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #443

@yixinshark yixinshark closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants