-
Notifications
You must be signed in to change notification settings - Fork 57
sync: from linuxdeepin/dde-session-shell #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#23
Reviewer's GuideThis PR syncs upstream changes from linuxdeepin/dde-session-shell by simplifying icon pixmap handling in the InhibitWarnView and adding initial Spanish translation templates for several regional variants. Class diagram for InhibitWarnView icon pixmap handling updateclassDiagram
class InhibitWarnView {
+void initUi()
- setNormalPixmap(QPixmap) for m_acceptBtn: now uses iconSize only
- setHoverPixmap(QPixmap) for m_acceptBtn: now uses iconSize only
- setNormalPixmap(QPixmap) for m_cancelBtn: now uses iconSize only
- setHoverPixmap(QPixmap) for m_cancelBtn: now uses iconSize only
}
InhibitWarnView --> AcceptButton : m_acceptBtn
InhibitWarnView --> CancelButton : m_cancelBtn
class AcceptButton {
+setNormalPixmap(QPixmap)
+setHoverPixmap(QPixmap)
}
class CancelButton {
+setNormalPixmap(QPixmap)
+setHoverPixmap(QPixmap)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.0.43 |
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#23
Summary by Sourcery
Sync source from linuxdeepin/dde-session-shell: update icon pixmap usage and include new Spanish translation files
Enhancements:
Documentation: