sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#25

Summary by Sourcery

Bug Fixes:

• Change CMake install directive to install deepin-greeter as a program instead of a file

[sourcery-ai]

Reviewer's Guide

Upstream synchronization of CMakeLists.txt to align installation directives and file formatting with linuxdeepin/dde-session-shell.

File-Level Changes

Change	Details	Files
Switch deepin-greeter installation to use PROGRAMS	Changed install(FILES) to install(PROGRAMS) for snipe/deepin-greeter to mark it executable at install time	CMakeLists.txt
Clean up trailing newline in CMakeLists.txt	Removed redundant end-of-file newline to match upstream formatting	CMakeLists.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 文件类型指定：

   • 在 install 命令中，使用 PROGRAMS 而不是 FILES 来指定可执行文件。这是正确的，因为 deepin-greeter 是一个可执行文件。确保所有可执行文件都使用 PROGRAMS 关键字。

2. 路径和文件名：

   • 确认 files/deepin-greeter 和 files/snipe/deepin-greeter 文件路径和文件名是否正确，并且这些文件确实存在于项目中。

3. 安装目标路径：

   • 确认 ${CMAKE_INSTALL_BINDIR}、${CMAKE_INSTALL_DATADIR} 和 ${CMAKE_INSTALL_SYSCONFDIR} 等变量在 CMakeLists.txt 中正确定义，并且路径是正确的。

4. 文件权限：

   • 考虑为安装的可执行文件设置适当的权限，以确保它们可以正确执行。可以使用 chmod 命令或 set_permissions 函数来设置权限。

5. 代码注释：

   • 在 CMakeLists.txt 中添加必要的注释，解释为什么需要安装这些文件以及它们的作用。这有助于其他开发者理解代码的目的。

6. 错误处理：

   • 检查是否有错误处理机制，例如在安装过程中如果某个文件不存在或路径错误，是否有相应的错误提示或处理逻辑。

7. 版本控制：

   • 确保在提交代码时，已经更新了相关的版本号和变更日志，以便于追踪和记录代码的变更。

8. 依赖管理：

   • 确认 CMakeLists.txt 中没有遗漏任何依赖项的声明，确保构建系统能够正确找到所有必要的库和头文件。

9. 代码风格：

   • 确保代码风格一致，例如缩进、空格和括号的使用等，遵循项目的编码规范。

10. 测试：

    • 在提交代码前，确保运行了所有相关的测试用例，包括单元测试和集成测试，以确保代码更改不会引入新的问题。

以上是针对 CMakeLists.txt 文件的一些改进建议，希望能够对你有所帮助。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment