Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

@deepin-ci-robot deepin-ci-robot commented Sep 18, 2025

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#47

Summary by Sourcery

Synchronize source from linuxdeepin/dde-session-shell by updating translations, adding reusable licensing metadata, and cleaning up obsolete files.

Bug Fixes:

  • Provide missing Russian translation for "Setup completed Start login" in the login-gesture plugin.

Enhancements:

  • Add REUSE.toml with SPDX annotations for project licensing information.

Chores:

  • Remove deprecated .reuse/dep5 file and delete outdated Spanish translation files.

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 18, 2025

Reviewer's Guide

This PR syncs upstream changes from linuxdeepin/dde-session-shell by completing a missing Russian translation, introducing standardized licensing metadata via a new REUSE.toml (and removing the old dep5), and cleaning up obsolete Spanish translation files.

File-Level Changes

Change Details Files
Completed missing Russian translation in the login-gesture plugin
  • Filled in the translation for 'Setup completed Start login' in the Russian UI file
plugins/login-gesture/translations/login-gesture_ru.ts
Updated licensing metadata to REUSE standard
  • Added REUSE.toml with SPDX package headers and file-level license annotations
  • Removed legacy .reuse/dep5 file
REUSE.toml
.reuse/dep5
Removed outdated Spanish translation files
  • Deleted es_419, es_AR, es_CL, and es_MX locale files
translations/dde-session-shell_es_419.ts
translations/dde-session-shell_es_AR.ts
translations/dde-session-shell_es_CL.ts
translations/dde-session-shell_es_MX.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot
Copy link

deepin-bot bot commented Sep 18, 2025

TAG Bot

New tag: 6.0.48
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #471

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#47
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

根据提供的git diff,我注意到这是一个从dep5格式迁移到REUSE.toml格式的许可证文件变更。以下是我的审查意见:

  1. 格式变更的合理性:
  • 从dep5格式迁移到REUSE.toml格式是合理的,因为REUSE.toml是更现代、更灵活的许可证声明格式
  • 这种变更有助于提高许可证信息的可读性和可维护性
  1. 潜在问题:
  • 在REUSE.toml中,"None"作为版权声明可能不够明确,建议使用更具体的声明方式,如"NOASSERTION"或"SPDX-Reference: NOASSERTION"
  • 部分文件的路径模式可能过于宽泛(如"**.pro"),这可能包含不相关文件,建议更精确地指定文件范围
  1. 改进建议:
  • 建议为所有文件指定明确的版权所有者,即使是"无版权"的情况也应使用标准表述
  • 对于使用通配符的路径模式,建议尽可能精确,避免包含不相关文件
  • 建议添加注释说明REUSE.toml文件的结构和用途,便于维护
  • 考虑将常用的路径模式定义为变量,减少重复代码
  1. 翻译改进:
  • 俄语翻译中的一些改进是合理的,比如将"Неверный Пароль"改为"Неверный пароль"(保持大小写一致性)
  • 移除多余空格和标点符号的修改也是正确的
  1. 其他建议:
  • 建议在REUSE.toml文件开头添加文件说明,解释其用途和更新方式
  • 考虑添加自动化测试来验证REUSE.toml中声明的文件是否存在以及许可证声明是否正确
  • 对于特别重要的文件(如核心代码),建议单独列出而不是使用通配符

总体而言,这次许可证格式的变更是一个积极的改进,但可以通过上述建议进一步提高其准确性和可维护性。

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 59880a4 into master Sep 25, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants