-
Notifications
You must be signed in to change notification settings - Fork 30
chore: rename deepin-kwin to kwin #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Log: refork kwin form uos, don't rename
|
Skipping CI for Draft Pull Request. |
log: rename deepin-kwin to kwin
|
TAG Bot TAG: 1.99.12 |
|
/integr-topic kwin-qt6 |
|
Alreadly latest topic integration with deepin-community/Repository-Integration#2693 |
|
/integr-topic kwin-qt6 |
|
Alreadly latest topic integration with deepin-community/Repository-Integration#2693 |
|
/topic kwin-qt6 |
|
Add topic: kwin-qt6 successed. |
deepin pr auto review代码审查意见:
以上是针对代码审查提出的改进意见,希望能够帮助到开发者。 |
Reviewer's Guide by SourceryThis pull request renames No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wineee - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a variable for the window manager executable name to avoid repetition.
- It might be good to update any related documentation or comments that mention the old name.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Log: refork kwin form uos, don't rename
Summary by Sourcery
Chores: